Skip to content

JSX Formatting issue #46781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philipwhite opened this issue Mar 27, 2018 · 1 comment
Closed

JSX Formatting issue #46781

philipwhite opened this issue Mar 27, 2018 · 1 comment
Assignees
Labels
formatting Source formatter issues javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@philipwhite
Copy link

philipwhite commented Mar 27, 2018

Issue Type: Bug

This snippet from the meteor tutorial does not get formatted cleanly. Note especially the ending label tag.

render() {
        return (
            <div className="container">
                <header>
                    <h1>Todo List ({this.props.incompleteCount})</h1>
                    <label className="hide-completed">
                        <input
                            type="checkbox"
                            readOnly
                            checked={this.state.hideCompleted}
                            onClick={this.toggleHideCompleted.bind(this)}
                        />
                        Hide Completed Tasks
          </label>
                    <AccountsUIWrapper />

                    <form className="new-task" onSubmit={this.handleSubmit.bind(this)} >
                        <input
                            type="text"
                            ref="textInput"
                            placeholder="Type to add new tasks"
                        />
                    </form>
                </header>

                <ul>
                    {this.renderTasks()}
                </ul>
            </div>
        );
    }

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:39:09.335Z)
OS version: Darwin x64 16.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
Load (avg) 2, 2, 2
Memory (System) 16.00GB (1.40GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Extensions: none Reproduces without extensions
@vscodebot vscodebot bot added the tasks Task system issues label Mar 27, 2018
@mjbvz mjbvz assigned mjbvz and unassigned dbaeumer Mar 28, 2018
@mjbvz mjbvz added javascript JavaScript support issues formatting Source formatter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed tasks Task system issues labels Mar 28, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 28, 2018

Thanks. This has the same root cause as microsoft/TypeScript#20766

Closing as upstream

@mjbvz mjbvz closed this as completed Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formatting Source formatter issues javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants