Moderation needed.

[KaranKad]

Describe issue

People are submitting bad or duplicate manifests without checking if the app already exists or not in this repository.
Some examples
Duplicate pr's - #14546 #14606 #14498 #14605 #14610
Bad pr's - #14393 #14362 #14389 #14551 #14523
Overwriting existing manifests with half of the information - #14544 #14382
Luckily not every pr is merged.

Solution

Create a group of active contributors who know what they are doing, with ability to close a pr so they can prevent bad or duplicate pr's from getting in.

[OfficialEsco]

1. voidtools.everything voidtools.everything version 1.4.1.1005 #14367 broke the repo because it got added under the same name but small K in the foldername...
2. voidtools.Everything voidtools.Everything version 1.4.1.1005 #14381 got overwritten and deleted one installer.
3. 7zip.7zip Update 7zip.7zip.installer.yaml #14408 changed the InstallerType to exe which would make the validation fail but it didn't.
4. VSRevoGroup.RevoUninstaller VSRevoGroup.RevoUninstaller version 2.2.5.0 #14428 duplicate
5. MarcinSzeniak.BCUninstaller MarcinSzeniak.BCUninstaller version 5.0.0.0 #14437 duplicate
6. PointPlanck.FileBot Added PointPlanck.FileBot version 4.9.3 #14283 duplicate, but FileBot.FileBot only had one manifest so i deleted that one instead
7. ZoomVideoCommunications,Inc.ZoomMeetingsInstaller ZoomVideoCommunications,Inc.ZoomMeetingsInstaller version 5.6.6 #14522 duplicate and bad PackageIdentifier
8. TimKosse.Filezilla TimKosse.Filezilla version 3.54.1 #14486 duplicate
9. Cloudflare,Inc.CloudflareWARP Cloudflare,Inc.CloudflareWARP version 1.4.107.0 #14587 duplicate and bad PackageIdentifier
10. PowerSoftwareLtd.PowerISO PowerSoftwareLtd.PowerISO version 7.9.0.0 #14582 duplicate
11. TonecInc.InternetDownloadManagerinstaller TonecInc.InternetDownloadManagerinstaller version 6, 38, 25, 1 #14495 bad PackageVersion
12. obsproject.com.OBSStudio obsproject.com.OBSStudio version 26.1.1 #14623 duplicate
13. Unity UnityTechnologiesApS.Unity2020.3.10f1(64-bit) version 2020.3.10f1 #14571 duplicate and bad PackageIdentifier
14. GoogleLLC.GoogleBackupandSync GoogleLLC.GoogleBackupandSync version 1.3.36.82 #14555 duplicate
15. Google.GoogleEarth Google.GoogleEarth version 1.3.36.82 #14422 duplicate
16. DuongDieuPhap.ImageGlass DuongDieuPhap.ImageGlass version 8.2.6.6 #14626 duplicate/overwritten
17. AkeoConsulting.Rufus AkeoConsulting.Rufus version 3.14.1788 #14406 duplicate
18. Foundry376,LLC.Mailspring Foundry376,LLC.Mailspring version 1.9.1 #14405 duplicate
19. OpenMediaLLC.4KVideoDownloader OpenMediaLLC.4KVideoDownloader version 4.16.0.4250 #14652 duplicate
20. Speccy.PiriformSoftwareLtd.Speccy Speccy.PiriformSoftwareLtd.Speccy version 1.32.0.774 #14671 and PiriformSoftware.Speccy version 1.32.0.774 #15041 duplicate
21. Revert "Manifest Update fore Piriform.Speccy v1.32" Revert "Manifest Update fore Piriform.Speccy v1.32" #14682 and Revert "Manifest Update fore Piriform.Speccy v1.32" #15037 reverting correct manifest to incorrect information
22. Guilded,Inc.Guilded Guilded,Inc.Guilded version 1.0.996954-release #14672 bad PackageIdentifier
23. Surfshark.Surfshark Surfshark.Surfshark version 2.8.4999 #14679 duplicate
24. DuongDieuPhap.ImageGlass DuongDieuPhap.ImageGlass version 8.2.6.6 #14746 duplicate
25. SaladTechnologies.Salad SaladTechnologies.Salad version 0.5.4 #14749 duplicate
26. uvncbvba.UltraVnc uvncbvba.UltraVnc version 1.3.2 #14699 wrong publisher (moved UltraVNC.UltraVNC to this)

[KaranKad]

1. (BraveSoftwareInc.BraveSoftwareUpdate) (BraveSoftwareInc.BraveSoftwareUpdate) version 1.25.68 #14691 duplicate with bad PackageIdentifier
2. Funkin'Team.FridayNightFunkin' Funkin'Team.FridayNightFunkin' version v2.8 #14716 bad PackageIdentifier
3. DolphinEmu.DolphinEmulatorProject DolphinEmu.DolphinEmulatorProject version 5.0 #14741 duplicate
4. DuongDieuPhap.ImageGlass DuongDieuPhap.ImageGlass version 8.2.6.6 #14746 duplicate
5. ppy.osu ppy.osu version 2021.524.0 #14747 duplicate
6. lunar_client.lunarclient lunar_client.lunarclient version 2.7.3 #14759 bad PackageIdentifier
7. NitroPDFIncNitroPDFPtyLtd.PrimoPDF NitroPDFIncNitroPDFPtyLtd.PrimoPDF version 5.1.0.2 #14763 bad PackageIdentifier and download url
8. Moonsworth,LLC.LunarClient Moonsworth,LLC.LunarClient version 2.7.3 #14767 bad PackageIdentifier
9. DonHOdon.h@free.fr.Notepad++ DonHOdon.h@free.fr.Notepad++ version 7.9.5.0 #14977 duplicate with bad PackageIdentifier
10. Microsoft.VisualStudio Microsoft.VisualStudio version 1.11.11451.0 #14970 just a really bad pr
11. CPUID,Inc.CPUIDCPU-Z CPUID,Inc.CPUIDCPU-Z version 1.96.1 #14979 duplicate with bad PackageIdentifier
12. kite.kite kite.kite version 1.2021.527.0 #14986 kite.kite version 1.2021.527.0 #14620 submitting same pr twice.
13. CyotekLtd.CyotekWebCopy CyotekLtd.CyotekWebCopy version 1.8.3.768 #14991 duplicate Publisher
14. CPUID,Inc.CPUIDpowerMAX CPUID,Inc.CPUIDpowerMAX version 1.00 #14989 bad PackageIdentifier (Fixed)
15. CyotekLtd.CyotekWebCopy CyotekLtd.CyotekWebCopy version 1.8.3.768 #14993 CyotekLtd.CyotekWebCopy version 1.8.3.768 #14991 submitting same pr twice. (Fixed)
16. Irium.Webcam Iriun Webcam version 2.6.6 #15000 duplicate. (deleted) (Fixed)
17. AprelTech,LLC.SilentInstallBuilder AprelTech,LLC.SilentInstallBuilder version 5.1.4.0 #14992 bad PackageIdentifier (Fixed)
18. Process.explorer Process.explorer version 16.41 #15005 Process.explorer version 16.41 #15006 submitting same pr twice.
19. GoogleLLC.GoogleUpdate GoogleLLC.GoogleUpdate version 91.0.4472.77 #15007 duplicate with bad PackageIdentifier (Fixed)
20. Mumble.Mumble134 Mumble.Mumble134 version 1.3.4 #15011 bad PackageIdentifier
21. ScratchFoundation.Scratch3 ScratchFoundation.Scratch3 version 3.22.0 #15014 bad duplicate (Fixed)
22. U.Freiberger.RobotKarol30 U.Freiberger.RobotKarol30 version 3.0 #15030 bad PackageIdentifier
23. FamatechCorp.AdvancedIPScanner FamatechCorp.AdvancedIPScanner version 2.5.3850 #15028 bad PackageIdentifier
24. ParagonSoftware.APFS ParagonSoftware.APFS version 2.1.97 #15055 duplicate Publisher (Fixed)
25. SonyInteractiveEntertainmentInc.PSRemotePlay SonyInteractiveEntertainmentInc.PSRemotePlay version 4.1.0.04020 #15057 bad PackageIdentifier (Fixed by Sony.PSRemotePlay version 4.1.0.04020 #15093)
26. fi.skyjake.Lagrange fi.skyjake.Lagrange version 1.50 #15058 bad PackageIdentifier (Fixed)
27. AppleInc.iCloud AppleInc.iCloud version 7.21.0.23 #15046 duplicate publisher
28. TheIridiumAuthors.IridiumBrowser TheIridiumAuthors.IridiumBrowser version 2020.11.85 #15097 TheIridiumAuthors.IridiumBrowser version 2020.11.85 #15096 submitting same pr twice. (Fixed)
29. BitSum.ProcessLasso.Beta BitSum.ProcessLasso.Beta version 10.1.0.23 #15119 bad PackageIdentifier
30. BitsumLLC.ProcessLasso BitsumLLC.ProcessLasso version 10.0.3.6 #15120 duplicate Publisher
31. BraveSoftwareInc.BraveSoftwareUpdate BraveSoftwareInc.BraveSoftwareUpdate version 1.3.101.0 #15126 duplicate
32. KakaoCorp.KakaoTalk Kakao.KakaoTalk version 3.2.7.2782 #15157 bad PackageIdentifier
33. Kakao.PotPlayer Kakao.PotPlayer version 1.7.21486 #15167 duplicate (Fixed)
34. RaspberryPi.RaspberryPiImager RaspberryPi.RaspberryPiImager version 1.6.2 #15184 duplicate publisher (Fixed)
35. Pylo.MCreator.Installer Pylo.MCreator.Installer version 2021.1 #15173 bad PackageIdentifier
36. OracleCorporation.OracleVMVirtualBox OracleCorporation.OracleVMVirtualBox version 6.1.22.144080 #15203 duplicate (Fixed)
37. m2070.samsung m2070.samsung version 2.00.01.24 #15209 m2070.samsung version 2.00.01.24 #15210 submitting same pr twice.
38. DiscordInc.Discord DiscordInc.Discord version 1.0.9002 #15228 duplicate (Fixed)
39. Discord.Discord Discord.Discord version 1.0.9002 #15222 Overwriting existing pr (Fixed)

[jedieaston]

I really really think that any new PackageIdentifer should have to be checked by someone on the winget team (or if they want to start a recognized contributor system I’d throw my hat in the ring). Fully automated adding of brand new packages will have tons of duplicates.

[Touchcreator]

What can I do to make my PackageIdentifier better?

[KaranKad]

What can I do to make my PackageIdentifier better?

Oh! my bad, I checked the download url https://github.com/CreativeDo/ZXPInstaller and saw that you submitted the PakageIdentifier as guideguide.ZXPInstaller, I thought it should have been CreativeDo.ZXPInstaller but now I checked their actual GitHub page.