Apply suggestions from code review

abrilgzz · danielluo-msft · commit 263e02a676ce · 2024-05-15T16:49:50.000-07:00
diff --git a/Service/GroupMembershipManagement/Common.DependencyInjection/ServiceCollectionExtensions.cs b/Service/GroupMembershipManagement/Common.DependencyInjection/ServiceCollectionExtensions.cs
@@ -16,9 +16,9 @@ public static IServiceCollection AddGraphAPIClient(this IServiceCollection servi
             {
                 var configuration = services.GetService<IConfiguration>();
                 var graphCredentials = services.GetService<IOptions<GraphCredentials>>().Value;
-                if (graphCredentials.AuthenticationType == AuthenticationType.Unknown || graphCredentials.AuthenticationType == default(AuthenticationType))
+                if (graphCredentials.AuthenticationType == AuthenticationType.Unknown)
                 {
-                    graphCredentials.AuthenticationType = MapStringToAuthenticationType("ClientSecret");
+                    graphCredentials.AuthenticationType = MapStringToAuthenticationType(configuration["GraphAPI:AuthenticationType"]);
                 }
                 var credential = FunctionAppDI.CreateAuthenticationProvider(graphCredentials, graphCredentials.AuthenticationType);
                 return new GraphServiceClient(credential);

Original file line number	Diff line number	Diff line change
`@@ -16,9 +16,9 @@ public static IServiceCollection AddGraphAPIClient(this IServiceCollection servi`
`16`	`16`	`{`
`17`	`17`	`var configuration = services.GetService<IConfiguration>();`
`18`	`18`	`var graphCredentials = services.GetService<IOptions<GraphCredentials>>().Value;`
`19`		`- if (graphCredentials.AuthenticationType == AuthenticationType.Unknown \|\| graphCredentials.AuthenticationType == default(AuthenticationType))`
	`19`	`+ if (graphCredentials.AuthenticationType == AuthenticationType.Unknown)`
`20`	`20`	`{`
`21`		`- graphCredentials.AuthenticationType = MapStringToAuthenticationType("ClientSecret");`
	`21`	`+ graphCredentials.AuthenticationType = MapStringToAuthenticationType(configuration["GraphAPI:AuthenticationType"]);`
`22`	`22`	`}`
`23`	`23`	`var credential = FunctionAppDI.CreateAuthenticationProvider(graphCredentials, graphCredentials.AuthenticationType);`
`24`	`24`	`return new GraphServiceClient(credential);`