Skip to content

Commit 53fe1cc

Browse files
committed
Fix to set the correct final onboarding query
1 parent 022db29 commit 53fe1cc

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

UI/web-app/src/pages/ManageMembership/ManageMembership.base.tsx

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ import {
4040
areAllSourcePartsValid,
4141
setJobDetailsForExistingJob,
4242
setIsEditingExistingJob,
43-
manageMembershipIsEditingExistingJob
43+
manageMembershipIsEditingExistingJob,
44+
manageMembershipCompositeQuery
4445
} from '../../store/manageMembership.slice';
4546
import { getGroupEndpoints, getGroupOnboardingStatus } from '../../store/manageMembership.api';
4647
import { NewJob } from '../../models/NewJob';
@@ -54,6 +55,7 @@ import { OnboardingSteps } from '../../models/OnboardingSteps';
5455
import { selectSelectedJobDetails, selectSelectedJobLoading } from '../../store/jobs.slice';
5556
import { fetchJobDetails } from '../../store/jobDetails.api';
5657
import { Loader } from '../../components/Loader';
58+
import { SyncJobQuery } from '../../models/SyncJobQuery';
5759

5860
const getClassNames = classNamesFunction<
5961
IManageMembershipStyleProps,
@@ -111,8 +113,6 @@ export const ManageMembershipBase: React.FunctionComponent<IManageMembershipProp
111113
}
112114
}, [dispatch, locationState]);
113115

114-
// Onboarding values
115-
const onboardingQuery = useSelector(manageMembershipQuery);
116116

117117
useEffect(() => {
118118
if (jobDetails) {
@@ -128,6 +128,15 @@ export const ManageMembershipBase: React.FunctionComponent<IManageMembershipProp
128128
const thresholdPercentageForRemovals = useSelector(manageMembershipThresholdPercentageForRemovals);
129129
const requestor = useSelector(selectAccountUsername);
130130
const isEditingExistingJob = useSelector(manageMembershipIsEditingExistingJob);
131+
const advancedViewQuery = useSelector(manageMembershipQuery);
132+
const sourcePartsQuery = useSelector(manageMembershipCompositeQuery);
133+
134+
let finalQuery: SyncJobQuery;
135+
if(!sourcePartsQuery || sourcePartsQuery.length === 0) {
136+
finalQuery = advancedViewQuery;
137+
} else {
138+
finalQuery = sourcePartsQuery;
139+
}
131140

132141
const handleSearchDestinationChange = (selectedDestinations: IPersonaProps[] | undefined) => {
133142
dispatch(setHasChanges(true));
@@ -192,7 +201,7 @@ export const ManageMembershipBase: React.FunctionComponent<IManageMembershipProp
192201
requestor: requestor ?? '',
193202
startDate: startDate,
194203
period: period,
195-
query: onboardingQuery,
204+
query: finalQuery,
196205
thresholdPercentageForAdditions: thresholdPercentageForAdditions,
197206
thresholdPercentageForRemovals: thresholdPercentageForRemovals,
198207
status: 'Idle',

0 commit comments

Comments
 (0)