Skip to content

Commit 6815a37

Browse files
author
yuqingyang
committed
Change threshold per mille
1 parent 5e74052 commit 6815a37

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

Infrastructure/data/template.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ param appConfigurationKeyData array = [
175175
}
176176
}
177177
{
178-
key: 'JobTrigger:JobPercentThreshold'
179-
value: '1'
178+
key: 'JobTrigger:JobPerMilleThreshold'
179+
value: '10'
180180
contentType: 'integer'
181181
tag: {
182182
tag1: 'JobTrigger'

Service/GroupMembershipManagement/DIConcreteTypes/JobTriggerConfig.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ public class JobTriggerConfig : IJobTriggerConfig
88
{
99
public JobTriggerConfig() {}
1010

11-
public JobTriggerConfig(bool gmmHasGroupReadWriteAllPermissions, int jobCountThreshold, int jobPercentThreshold)
11+
public JobTriggerConfig(bool gmmHasGroupReadWriteAllPermissions, int jobCountThreshold, int jobPerMilleThreshold)
1212
{
1313
GMMHasGroupReadWriteAllPermissions = gmmHasGroupReadWriteAllPermissions;
1414
JobCountThreshold = jobCountThreshold;
15-
JobPercentThreshold = jobPercentThreshold;
15+
JobPerMilleThreshold = jobPerMilleThreshold;
1616
}
1717

1818
public bool GMMHasGroupReadWriteAllPermissions { get; set; }
1919
public int JobCountThreshold { get; set; }
20-
public int JobPercentThreshold { get; set; }
20+
public int JobPerMilleThreshold { get; set; }
2121
}
2222
}

Service/GroupMembershipManagement/Hosts/JobTrigger/Function/Startup.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public override void Configure(IFunctionsHostBuilder builder)
4040
{
4141
settings.GMMHasGroupReadWriteAllPermissions = GetBoolSetting(configuration, "JobTrigger:IsGroupReadWriteAllGranted", false);
4242
settings.JobCountThreshold = GetIntSetting(configuration, "JobTrigger:JobCountThreshold", 10);
43-
settings.JobPercentThreshold = GetIntSetting(configuration, "JobTrigger:JobPercentThreshold", 1);
43+
settings.JobPerMilleThreshold = GetIntSetting(configuration, "JobTrigger:JobPerMilleThreshold", 10);
4444
});
4545

4646
builder.Services.AddSingleton<IJobTriggerConfig>(services => services.GetService<IOptions<JobTriggerConfig>>().Value);

Service/GroupMembershipManagement/Hosts/JobTrigger/Services/JobTriggerService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,9 @@ private bool HasJobTriggerThresholdExceeded(int syncJobsCount, int totalSyncJobs
237237
}
238238
else if (syncJobsCount >= _jobTriggerConfig.JobCountThreshold)
239239
{
240-
double percentage = ((double)syncJobsCount / totalSyncJobsCount) * 100;
240+
double PerMille = ((double)syncJobsCount / totalSyncJobsCount) * 1000;
241241

242-
if (percentage >= _jobTriggerConfig.JobPercentThreshold)
242+
if (PerMille >= _jobTriggerConfig.JobPerMilleThreshold)
243243
{
244244
return true;
245245
}

Service/GroupMembershipManagement/Repositories.Contracts/InjectConfig/IJobTriggerConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public interface IJobTriggerConfig
66
{
77
public bool GMMHasGroupReadWriteAllPermissions { get; }
88
public int JobCountThreshold { get; }
9-
public int JobPercentThreshold { get; }
9+
public int JobPerMilleThreshold { get; }
1010

1111
}
1212
}

Service/GroupMembershipManagement/Repositories.Mocks/MockJobTriggerConfig.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ public class MockJobTriggerConfig : IJobTriggerConfig
88
{
99
public bool GMMHasGroupReadWriteAllPermissions { get; set; }
1010
public int JobCountThreshold { get; set; }
11-
public int JobPercentThreshold { get; set; }
11+
public int JobPerMilleThreshold { get; set; }
1212

1313
public MockJobTriggerConfig()
1414
{
1515
GMMHasGroupReadWriteAllPermissions = false;
1616
JobCountThreshold = 4;
17-
JobPercentThreshold = 25;
17+
JobPerMilleThreshold = 250;
1818

1919
}
2020
}

0 commit comments

Comments
 (0)