Skip to content

Change retrunType for M365 report functions to Edm.Steam #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peombwa opened this issue Apr 30, 2021 · 7 comments
Closed

Change retrunType for M365 report functions to Edm.Steam #79

peombwa opened this issue Apr 30, 2021 · 7 comments
Assignees

Comments

@peombwa
Copy link
Member

peombwa commented Apr 30, 2021

The converted OpenAPI document currently represents response type of most report functions as application/json instead of application/octet-stream. To solve this, we need to ensure that response types of functions bound to reportRoot are accurately represented in the converted OpenAPI. Without this, code generators won't be able to know how to properly handle responses.

Example

Currently

This CSDL with the wrong return type:
image
image

Gets converted to this in OpenAPI:
image

Expected

For reports to function as described in MS Graph docs, we need to ensure that they are described as shown below:
image

Related to microsoftgraph/msgraph-sdk-powershell#407

AB#9223

@darrelmiller
Copy link
Contributor

@peombwa If the returnType was Edm.Stream, would that fix our issues?

@peombwa
Copy link
Member Author

peombwa commented Jul 13, 2021

@darrelmiller, I totally missed this. Yes, having the returnType as Edm.Steam will fix this. We should also add $format query parameter to all M365 reports.

I'll transfer the issue to the metadata repo since this work will involve XSLT transform.

@peombwa peombwa transferred this issue from microsoftgraph/microsoft-graph-devx-api Jul 13, 2021
@peombwa peombwa changed the title Correct Content-Type For Reports Change retrunType for M365 report functions to Edm.Steam Jul 13, 2021
@weyCC81
Copy link

weyCC81 commented Oct 6, 2021

@peombwa Is there an update on this?

@joshtransient
Copy link

Any updates to this yet?

@silijon
Copy link

silijon commented Feb 10, 2022

Also looking for an update on this. As far as we can tell, the entire Microsoft.Graph.Reports powershell sdk module is irretrievably broken until this is fixed.

@DanijelkMSFT
Copy link

@silijon agree it would be great to see this fixed until then you may use this workaround with Peter provided me.
As it allows you to still use Graph Powershell und simply move forward as soon as the issue is fixed

Invoke-MgGraphRequest -Uri "https://graph.microsoft.com/beta/reports/getM365AppUserDetail(period='D7')/content" -OutputFilePath test.csv

@irvinesunday
Copy link
Contributor

Resolved with #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants