Skip to content

ResponseHandler should look at Content-Type before trying to deserialize as JSON #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darrelmiller opened this issue Aug 28, 2019 · 2 comments
Assignees
Labels
Bug Something isn't working Kiota Is solved by Kiota or will be addressed in Kiota
Milestone

Comments

@darrelmiller
Copy link
Contributor

darrelmiller commented Aug 28, 2019

See microsoftgraph/msgraph-sdk-dotnet#534

We should only pass content on to the Serializer if the content-Type is application/json otherwise we need to find some other way of returning the payload.

This is going to need to be fixed in the snippet generator as this is wrong https://docs.microsoft.com/en-us/graph/api/reportroot-getmailboxusagedetail?view=graph-rest-1.0&tabs=csharp#request

AB#7197

@andrueastman
Copy link
Member

This should be resolved with Kiota as the ParseNodeRegistry uses the Content-Type to determine the factory to use to handle the response.

Ref here

@andrueastman andrueastman added the Kiota Is solved by Kiota or will be addressed in Kiota label Feb 18, 2022
@andrueastman andrueastman self-assigned this May 6, 2022
@andrueastman
Copy link
Member

Closing this now as this is validated with the latest kiota based preview versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Kiota Is solved by Kiota or will be addressed in Kiota
Projects
None yet
Development

No branches or pull requests

4 participants