Skip to content

Connect-Graph Enhancements - Metaissue #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darrelmiller opened this issue Mar 17, 2020 · 6 comments
Closed

Connect-Graph Enhancements - Metaissue #142

darrelmiller opened this issue Mar 17, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@darrelmiller
Copy link
Contributor

darrelmiller commented Mar 17, 2020

Related to issues: #125 , #123, #102, #46, #52, #113
AB#7439

@darrelmiller darrelmiller added this to the 0.5.0 milestone Mar 17, 2020
@ghost ghost added the ToTriage label Mar 17, 2020
@ghost
Copy link

ghost commented Mar 18, 2020

I would rename Connect-Graph to Connect-MgService. This makes a bit more sense than Connect-MgGraph (Connect Microsoft Graph Graph?) and Connect-MgAccount since we're connecting to the Microsoft Graph service and not a reference to an account.

Plus it would be like the SPO cmdlets and hopefully would start a movement to get other services to adopt the same format :-)

@darrelmiller
Copy link
Contributor Author

@tseward Thanks for your input. I shopped the "service" suffix around a bit and the feedback is that the term is a bit overloaded and it conflicts with some of the other work that is going on. There wasn't much enthusiasm for the Account suffix and there wasn't much objection to Connect-MgGraph. So for the moment, we are planning to go with Connect-MgGraph and alias Connect-Graph so that we don't break existing folks.

@darrelmiller
Copy link
Contributor Author

darrelmiller commented Mar 18, 2020

Parameter Delegated Application-Only MSI Plan
-Scopes X    
-TenantId X X  
-ClientId (ApplicationId)   X  Alias ApplicationId
-CertificateName   X  
-CertificateThumbprint   X  
-ForceRefresh X X  
-AccessToken ? ? ? GA
-Credential   ?  Post V1
-Environment X X X Post V1
-Identity     X Waiting for Graph Core 2
-Certificate   ?   Post V1
-ContextName ? ? No decision
-UseDeviceCode ?    GA Default in Linux, Option in Windows

@BrianTJackett
Copy link
Contributor

BrianTJackett commented Mar 31, 2020

On my work machine I have a number of Connect-* commandlets. Here are a few:

  • Connect-AzureAD <-- only the module prefix of "AzureAD"
  • Connect-SPOService <-- prefix + "Service", already mentioned above
  • Connect-AzAccount <-- prefix + "Account", not really notion of Account in Graph
  • Connect-PnPOnline <-- prefix + "Online", to distinguish from on-prem SharePoint
  • Connect-ExchangeOnline <-- not the prefix nor an alias, module then uses "EXO" as prefix

Using the prefix + something seems to be the norm (at least for MSFT created modules). I would be in favor of these:

  • Connect-Mg with alias to Connect-Graph
  • Connect-MgGraph with alias Connect-Graph

@ddyett
Copy link
Contributor

ddyett commented Jul 8, 2020

support for interactive credential by default on windows.

@maisarissi
Copy link

Closing this since all enhancements were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants