fix: parse the mime metadata when do get/head object (#2106)

Author: jiuker

utils.go

@@ -30,6 +30,7 @@ import (
 	"hash"
 	"io"
 	"math/rand"
+	"mime"
 	"net"
 	"net/http"
 	"net/url"
@@ -210,6 +211,7 @@ func extractObjMetadata(header http.Header) http.Header {
 		"X-Amz-Server-Side-Encryption",
 		"X-Amz-Tagging-Count",
 		"X-Amz-Meta-",
+		"X-Minio-Meta-",
 		// Add new headers to be preserved.
 		// if you add new headers here, please extend
 		// PutObjectOptions{} to preserve them
@@ -223,6 +225,16 @@ func extractObjMetadata(header http.Header) http.Header {
 				continue
 			}
 			found = true
+			if prefix == "X-Amz-Meta-" || prefix == "X-Minio-Meta-" {
+				for index, val := range v {
+					if strings.HasPrefix(val, "=?") {
+						decoder := mime.WordDecoder{}
+						if decoded, err := decoder.DecodeHeader(val); err == nil {
+							v[index] = decoded
+						}
+					}
+				}
+			}
 			break
 		}
 		if found {

utils_test.go

@@ -21,7 +21,11 @@ import (
 	"errors"
 	"fmt"
 	"math/rand"
+	"mime"
+	"net/http"
 	"net/url"
+	"reflect"
+	"strings"
 	"testing"
 	"time"
 
@@ -467,3 +471,74 @@ func TestFullObjectChecksum64(t *testing.T) {
 		})
 	}
 }
+
+func TestExtractObjMetadata(t *testing.T) {
+	tests := []struct {
+		name   string
+		header http.Header
+		want   http.Header
+	}{
+		{
+			name: "Test with valid header",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{"test"},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{"test"},
+			},
+		},
+		{
+			name: "Test with valid header with QEncoding characters",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{mime.QEncoding.Encode("UTF-8", "öha, das")},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{"öha, das"},
+			},
+		},
+		{
+			name: "Test with valid header with BEncoding characters",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{mime.BEncoding.Encode("UTF-8", "öha, das")},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{"öha, das"},
+			},
+		},
+		{
+			name: "Test with valid header with multi-QEncoding characters",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{mime.QEncoding.Encode("UTF-8", strings.Repeat("öha, das", 100))},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{strings.Repeat("öha, das", 100)},
+			},
+		},
+		{
+			name: "Test with valid header with multi-BEncoding characters",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{mime.BEncoding.Encode("UTF-8", strings.Repeat("öha, das", 100))},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{strings.Repeat("öha, das", 100)},
+			},
+		},
+		{
+			name: "Test with valid header with multi-BEncoding characters",
+			header: http.Header{
+				"X-Minio-Meta-Test": []string{mime.BEncoding.Encode("UTF-8", strings.Repeat("öha, das", 100)), mime.BEncoding.Encode("UTF-8", strings.Repeat("öha, das123", 100))},
+			},
+			want: http.Header{
+				"X-Minio-Meta-Test": []string{strings.Repeat("öha, das", 100), strings.Repeat("öha, das123", 100)},
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := extractObjMetadata(tt.header)
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("extractObjMetadata() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}