Skip to content

Commit 8d3adc2

Browse files
committed
fix revised comments
1 parent e014662 commit 8d3adc2

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

src/internal/client.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,8 @@ export class TypedClient {
986986
await this.makeRequestAsyncOmit({ method, bucketName, query }, '', [200, 204], '')
987987
}
988988

989-
setBucketReplication(bucketName: string, replicationConfig: ReplicationConfigOpts, callback: NoResultCallback): void
989+
setBucketReplication(bucketName: string, replicationConfig: ReplicationConfigOpts): void
990+
async setBucketReplication(bucketName: string, replicationConfig: ReplicationConfigOpts): Promise<void>
990991
async setBucketReplication(bucketName: string, replicationConfig: ReplicationConfigOpts) {
991992
if (!isValidBucketName(bucketName)) {
992993
throw new errors.InvalidBucketNameError('Invalid bucket name: ' + bucketName)
@@ -1020,7 +1021,8 @@ export class TypedClient {
10201021
await this.makeRequestAsyncOmit({ method, bucketName, query, headers }, payload)
10211022
}
10221023

1023-
getBucketReplication(bucketName: string, callback: ResultCallback<ReplicationConfig>): void
1024+
getBucketReplication(bucketName: string): void
1025+
async getBucketReplication(bucketName: string): Promise<ReplicationConfig>
10241026
async getBucketReplication(bucketName: string) {
10251027
if (!isValidBucketName(bucketName)) {
10261028
throw new errors.InvalidBucketNameError('Invalid bucket name: ' + bucketName)
@@ -1071,12 +1073,7 @@ export class TypedClient {
10711073
return parseObjectLegalHoldConfig(strRes)
10721074
}
10731075

1074-
setObjectLegalHold(
1075-
bucketName: string,
1076-
objectName: string,
1077-
setOpts?: PutObjectLegalHoldOptions,
1078-
callback?: NoResultCallback,
1079-
): void
1076+
setObjectLegalHold(bucketName: string, objectName: string, setOpts?: PutObjectLegalHoldOptions): void
10801077
async setObjectLegalHold(
10811078
bucketName: string,
10821079
objectName: string,

src/internal/type.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,9 @@ export type ResultCallback<T> = (error: Error | null, result: T) => void
195195
export type GetObjectLegalHoldOptions = {
196196
versionId: string
197197
}
198-
198+
/**
199+
* @deprecated keep for backward compatible, use `LEGAL_HOLD_STATUS` instead
200+
*/
199201
export type LegalHoldStatus = LEGAL_HOLD_STATUS
200202

201203
export type PutObjectLegalHoldOptions = {

0 commit comments

Comments
 (0)