Merge pull request #1117 from mintlayer/p2p_addresses_refactor

Remove BannableAddress generic (p2p)

Author: pavel-kokolemin

dns_server/src/crawler_p2p/crawler_manager/tests/mock_manager.rs

@@ -19,7 +19,7 @@
 
 use std::{
     collections::BTreeMap,
-    net::{IpAddr, SocketAddr},
+    net::SocketAddr,
     sync::{Arc, Mutex},
     time::Duration,
 };
@@ -117,7 +117,6 @@ pub struct MockSyncingEventReceiver {}
 impl NetworkingService for MockNetworkingService {
     type Transport = ();
     type Address = SocketAddr;
-    type BannableAddress = IpAddr;
     type ConnectivityHandle = MockConnectivityHandle;
     type MessagingHandle = ();
     type SyncingEventReceiver = MockSyncingEventReceiver;

p2p/benches/benches.rs

@@ -13,11 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::{
-    collections::BTreeSet,
-    net::{IpAddr, SocketAddr},
-    sync::Arc,
-};
+use std::{collections::BTreeSet, net::SocketAddr, sync::Arc};
 
 use common::chain::config::create_unit_test_config;
 use criterion::{criterion_group, criterion_main, Criterion};
@@ -34,13 +30,9 @@ pub fn peer_db(c: &mut Criterion) {
     let db_store = peerdb_inmemory_store();
     let chain_config = create_unit_test_config();
     let p2p_config = Arc::new(test_p2p_config());
-    let mut peerdb = PeerDb::<SocketAddr, IpAddr, _>::new(
-        &chain_config,
-        p2p_config,
-        Default::default(),
-        db_store,
-    )
-    .unwrap();
+    let mut peerdb =
+        PeerDb::<SocketAddr, _>::new(&chain_config, p2p_config, Default::default(), db_store)
+            .unwrap();
 
     for _ in 0..100000 {
         peerdb.peer_discovered(TestTcpAddressMaker::new());

p2p/src/interface/p2p_interface.rs

@@ -16,7 +16,9 @@
 use std::sync::Arc;
 
 use common::chain::SignedTransaction;
-use p2p_types::{ip_or_socket_address::IpOrSocketAddress, p2p_event::P2pEvent};
+use p2p_types::{
+    bannable_address::BannableAddress, ip_or_socket_address::IpOrSocketAddress, p2p_event::P2pEvent,
+};
 
 use crate::{interface::types::ConnectedPeer, types::peer_id::PeerId};
 
@@ -25,9 +27,9 @@ pub trait P2pInterface: Send + Sync {
     async fn connect(&mut self, addr: IpOrSocketAddress) -> crate::Result<()>;
     async fn disconnect(&mut self, peer_id: PeerId) -> crate::Result<()>;
 
-    async fn list_banned(&mut self) -> crate::Result<Vec<String>>;
-    async fn ban(&mut self, addr: String) -> crate::Result<()>;
-    async fn unban(&mut self, addr: String) -> crate::Result<()>;
+    async fn list_banned(&mut self) -> crate::Result<Vec<BannableAddress>>;
+    async fn ban(&mut self, addr: BannableAddress) -> crate::Result<()>;
+    async fn unban(&mut self, addr: BannableAddress) -> crate::Result<()>;
 
     async fn get_peer_count(&self) -> crate::Result<usize>;
     async fn get_bind_addresses(&self) -> crate::Result<Vec<String>>;

p2p/src/interface/p2p_interface_impl.rs

@@ -17,10 +17,10 @@ use std::sync::Arc;
 
 use common::chain::SignedTransaction;
 use mempool::TxOrigin;
-use p2p_types::ip_or_socket_address::IpOrSocketAddress;
+use p2p_types::{bannable_address::BannableAddress, ip_or_socket_address::IpOrSocketAddress};
 
 use crate::{
-    error::{ConversionError, P2pError},
+    error::P2pError,
     interface::{p2p_interface::P2pInterface, types::ConnectedPeer},
     net::NetworkingService,
     types::peer_id::PeerId,
@@ -31,7 +31,7 @@ use crate::{
 #[async_trait::async_trait]
 impl<T> P2pInterface for P2p<T>
 where
-    T: NetworkingService,
+    T: NetworkingService + Send + Sync,
     T::MessagingHandle: MessagingService,
 {
     async fn connect(&mut self, addr: IpOrSocketAddress) -> crate::Result<()> {
@@ -50,29 +50,23 @@ where
         rx.await?
     }
 
-    async fn list_banned(&mut self) -> crate::Result<Vec<String>> {
+    async fn list_banned(&mut self) -> crate::Result<Vec<BannableAddress>> {
         let (tx, rx) = oneshot_nofail::channel();
         self.tx_peer_manager
             .send(PeerManagerEvent::ListBanned(tx))
             .map_err(|_| P2pError::ChannelClosed)?;
         let list = rx.await?;
-        Ok(list.iter().map(ToString::to_string).collect())
+        Ok(list)
     }
-    async fn ban(&mut self, addr: String) -> crate::Result<()> {
+    async fn ban(&mut self, addr: BannableAddress) -> crate::Result<()> {
         let (tx, rx) = oneshot_nofail::channel();
-        let addr = addr
-            .parse::<T::BannableAddress>()
-            .map_err(|_| P2pError::ConversionError(ConversionError::InvalidAddress(addr)))?;
         self.tx_peer_manager
             .send(PeerManagerEvent::Ban(addr, tx))
             .map_err(|_| P2pError::ChannelClosed)?;
         rx.await?
     }
-    async fn unban(&mut self, addr: String) -> crate::Result<()> {
+    async fn unban(&mut self, addr: BannableAddress) -> crate::Result<()> {
         let (tx, rx) = oneshot_nofail::channel();
-        let addr = addr
-            .parse::<T::BannableAddress>()
-            .map_err(|_| P2pError::ConversionError(ConversionError::InvalidAddress(addr)))?;
         self.tx_peer_manager
             .send(PeerManagerEvent::Unban(addr, tx))
             .map_err(|_| P2pError::ChannelClosed)?;

p2p/src/interface/p2p_interface_impl_delegation.rs

@@ -19,7 +19,7 @@ use std::{
 };
 
 use common::chain::SignedTransaction;
-use p2p_types::ip_or_socket_address::IpOrSocketAddress;
+use p2p_types::{bannable_address::BannableAddress, ip_or_socket_address::IpOrSocketAddress};
 
 use crate::{types::peer_id::PeerId, P2pEvent};
 
@@ -37,13 +37,13 @@ impl<T: Deref<Target = dyn P2pInterface> + DerefMut<Target = dyn P2pInterface> +
         self.deref_mut().disconnect(peer_id).await
     }
 
-    async fn list_banned(&mut self) -> crate::Result<Vec<String>> {
+    async fn list_banned(&mut self) -> crate::Result<Vec<BannableAddress>> {
         self.deref_mut().list_banned().await
     }
-    async fn ban(&mut self, addr: String) -> crate::Result<()> {
+    async fn ban(&mut self, addr: BannableAddress) -> crate::Result<()> {
         self.deref_mut().ban(addr).await
     }
-    async fn unban(&mut self, addr: String) -> crate::Result<()> {
+    async fn unban(&mut self, addr: BannableAddress) -> crate::Result<()> {
         self.deref_mut().unban(addr).await
     }
 

p2p/src/lib.rs

@@ -35,6 +35,7 @@ pub use crate::{
 };
 
 use std::{
+    marker::PhantomData,
     net::{Ipv4Addr, Ipv6Addr, SocketAddr},
     sync::Arc,
 };
@@ -78,7 +79,7 @@ pub type Result<T> = core::result::Result<T, P2pError>;
 
 struct P2p<T: NetworkingService> {
     /// A sender for the peer manager events.
-    pub tx_peer_manager: mpsc::UnboundedSender<PeerManagerEvent<T>>,
+    pub tx_peer_manager: mpsc::UnboundedSender<PeerManagerEvent>,
     mempool_handle: MempoolHandle,
 
     backend_shutdown_sender: oneshot::Sender<()>,
@@ -92,11 +93,13 @@ struct P2p<T: NetworkingService> {
     sync_manager_task: JoinHandle<()>,
 
     subscribers_sender: mpsc::UnboundedSender<P2pEventHandler>,
+
+    _phantom: PhantomData<T>,
 }
 
 impl<T> P2p<T>
 where
-    T: 'static + NetworkingService + Send,
+    T: 'static + NetworkingService + Send + Sync,
     T::ConnectivityHandle: ConnectivityService<T>,
     T::MessagingHandle: MessagingService,
     T::SyncingEventReceiver: SyncingEventReceiver,
@@ -198,6 +201,7 @@ where
             peer_manager_task,
             sync_manager_task,
             subscribers_sender,
+            _phantom: PhantomData,
         })
     }
 

p2p/src/net/default_backend/mod.rs

@@ -102,7 +102,6 @@ pub struct SyncingReceiver {
 impl<T: TransportSocket> NetworkingService for DefaultNetworkingService<T> {
     type Transport = T;
     type Address = T::Address;
-    type BannableAddress = T::BannableAddress;
     type ConnectivityHandle = ConnectivityHandle<Self, T>;
     type MessagingHandle = MessagingHandle<T>;
     type SyncingEventReceiver = SyncingReceiver;

p2p/src/net/default_backend/transport/impls/channel.rs

@@ -84,7 +84,6 @@ impl MpscChannelTransport {
 #[async_trait]
 impl TransportSocket for MpscChannelTransport {
     type Address = SocketAddr;
-    type BannableAddress = IpAddr;
     type Listener = ChannelListener;
     type Stream = ChannelStream;
 

p2p/src/net/default_backend/transport/impls/socks5.rs

@@ -13,10 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::{
-    net::{IpAddr, SocketAddr},
-    sync::Arc,
-};
+use std::{net::SocketAddr, sync::Arc};
 
 use async_trait::async_trait;
 use futures::future::BoxFuture;
@@ -48,7 +45,6 @@ impl Socks5TransportSocket {
 #[async_trait]
 impl TransportSocket for Socks5TransportSocket {
     type Address = SocketAddr;
-    type BannableAddress = IpAddr;
     type Listener = Socks5TransportListener;
     type Stream = Socks5TransportStream;
 

p2p/src/net/default_backend/transport/impls/stream_adapter/wrapped_transport/tests.rs

@@ -141,7 +141,6 @@ impl TestTransport {
 #[async_trait]
 impl TransportSocket for TestTransport {
     type Address = <MpscChannelTransport as TransportSocket>::Address;
-    type BannableAddress = <MpscChannelTransport as TransportSocket>::BannableAddress;
     type Listener = TestListener;
     type Stream = <MpscChannelTransport as TransportSocket>::Stream;