Merge pull request #1166 from mintlayer/done-deal

Accumulated changes from Gitlab

Author: TheQuantumPhysicist

.github/workflows/build.yml

@@ -3,7 +3,7 @@ name: build
 on:
   push:
     branches:
-      - '**' # target all branches
+      - "**" # target all branches
   pull_request:
     branches:
       - master
@@ -14,7 +14,6 @@ env:
   RUST_BACKTRACE: full
 
 jobs:
-
   rustfmt:
     runs-on: ubuntu-latest
     steps:
@@ -23,6 +22,8 @@ jobs:
         with:
           concurrent_skipping: "same_content_newer"
           skip_after_successful_duplicate: "true"
+      - name: Install dependencies
+        run: sudo apt-get install -yqq --no-install-recommends build-essential libgtk-3-dev python3 python3-toml
       - uses: actions/checkout@v2
       - name: Install rust stable
         uses: actions-rs/toolchain@v1
@@ -82,6 +83,8 @@ jobs:
         with:
           concurrent_skipping: "same_content_newer"
           skip_after_successful_duplicate: "true"
+      - name: Install dependencies
+        run: sudo apt-get install -yqq --no-install-recommends build-essential libgtk-3-dev python3 python3-toml
       - uses: actions/checkout@v2
       - name: Install rust stable
         uses: actions-rs/toolchain@v1
@@ -142,4 +145,3 @@ jobs:
         with:
           name: macos-functional-test-artifacts
           path: target/tmp
-

.github/workflows/code_checks.yml

@@ -17,6 +17,8 @@ jobs:
         with:
           concurrent_skipping: "same_content_newer"
           skip_after_successful_duplicate: "true"
+      - name: Install dependencies
+        run: sudo apt-get install -yqq --no-install-recommends build-essential libgtk-3-dev python3 python3-toml
       - uses: actions/checkout@v1
       - run: rustup component add clippy
 
@@ -27,6 +29,7 @@ jobs:
           args: >
             --all-features --workspace --all-targets --
             -D warnings
+            -A clippy::unnecessary_literal_unwrap
             -A clippy::new_without_default
             -A unknown_lints
             -W clippy::implicit_saturating_sub
@@ -62,8 +65,8 @@ jobs:
           concurrent_skipping: "same_content_newer"
           skip_after_successful_duplicate: "true"
       - uses: actions/checkout@v1
-      - run: pip install -r ./.github/scripts/requirements.txt
-      - run: ./.github/scripts/codecheck.py
+      - run: pip install -r ./build-tools/codecheck/requirements.txt
+      - run: ./build-tools/codecheck/codecheck.py
 
   cargo_deny_checks:
     name: Cargo deny check licenses and advisories

.github/workflows/coverage.yml

@@ -1,7 +1,7 @@
 on:
   push:
     branches:
-      - '**' # target all branches
+      - "**" # target all branches
   pull_request:
     branches:
       - master
@@ -17,11 +17,13 @@ jobs:
         with:
           concurrent_skipping: "same_content_newer"
           skip_after_successful_duplicate: "true"
+      - name: Install dependencies
+        run: sudo apt-get install -yqq --no-install-recommends build-essential libgtk-3-dev python3 python3-toml
       - uses: actions/checkout@v1
       - uses: actions-rs/toolchain@v1
         with:
           # TODO: Inspect coverage, and change toolchain to stable
-          toolchain: nightly-2023-04-10
+          toolchain: nightly-2023-08-01
           override: true
       - uses: actions-rs/cargo@v1
         with:
@@ -34,12 +36,11 @@ jobs:
           RUST_LOG: debug
           RUST_BACKTRACE: full
           CARGO_INCREMENTAL: 0
-          RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
-          RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
+          RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests"
+          RUSTDOCFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests"
       - id: coverage
         uses: actions-rs/[email protected]
       - uses: actions/upload-artifact@v2
         with:
           name: code-coverage-report
           path: ${{ steps.coverage.outputs.report }}
-

.gitlab-ci.yml

@@ -0,0 +1,78 @@
+image: "rust:latest"
+
+stages:
+  - build_clean
+  - test_fmt
+  - code_checks
+  - test_clippy
+  - test_cargo
+  - build_cargo
+  - test_cargo_deny
+  - test_functional
+  - test_sighash
+
+variables:
+  RUST_LOG: debug
+  RUST_BACKTRACE: full
+
+  # Create a random path to avoid collisions
+  GIT_CLONE_PATH: $CI_BUILDS_DIR/$CI_PIPELINE_ID/mintlayer-core
+
+workflow:
+  rules:
+    - if: $CI_PIPELINE_SOURCE == "web"
+    - if: $CI_PIPELINE_SOURCE == "merge_request_event"
+
+before_script:
+  - apt-get update -yqq
+  - apt-get install -yqq --no-install-recommends build-essential libgtk-3-dev python3 python3-toml
+
+build:clean:
+  stage: build_clean
+  script:
+    - rm -rf target
+
+test:fmt:
+  stage: test_fmt
+  script:
+    - rustup component add rustfmt
+    - cargo fmt --all -- --check
+
+test:code_checks:
+  stage: code_checks
+  script:
+    - ./build-tools/codecheck/codecheck.py
+
+test:clippy:
+  stage: test_clippy
+  script:
+    - rustup component add clippy
+    - cargo clippy --all-features --workspace --all-targets -- -D warnings -A clippy::unnecessary_literal_unwrap -A clippy::new_without_default -W clippy::implicit_saturating_sub -W clippy::implicit_clone -W clippy::map_unwrap_or -W clippy::unnested_or_patterns -W clippy::manual_assert -W clippy::unused_async -W clippy::mut_mut -W clippy::todo
+    - cargo clippy --all-features --workspace --lib --bins --examples -- -A clippy::all -D clippy::float_arithmetic -W clippy::unwrap_used -W clippy::dbg_macro -W clippy::items_after_statements -W clippy::fallible_impl_from -W clippy::string_slice
+
+test:cargo:
+  stage: test_cargo
+  script:
+    - rustc --version && cargo --version
+    - cargo test --release --all --workspace --verbose
+
+build:cargo:
+  stage: build_cargo
+  script:
+    - cargo build --release --all --locked
+
+test:cargo_deny:
+  stage: test_cargo_deny
+  script:
+    - cargo install cargo-deny
+    - cargo deny check advisories licenses
+
+test:func:
+  stage: test_functional
+  script:
+    - cargo test --release -p mintlayer-test --test functional -- --ignored
+
+test:sighash:
+  stage: test_sighash
+  script:
+    - cargo test --release -p common mixed_sighash_types -- --ignored

.gitlab/CODEOWNERS

@@ -0,0 +1 @@
+* @muursh @TheQuantumPhysicist @erubboli

CONTRIBUTING.md

@@ -4,15 +4,15 @@
 
 If you want to contribute but have no idea what to start working on, feel free to check the [issues](https://github.com/mintlayer/mintlayer-core/issues) or grep for "TODO" in the code. If you have a proposal for a major change or feature that we haven't outlined before, the best idea would be to open an issue or pull request to discuss the idea before you delve too deeply into it, as there may be a good reason we haven't gone that route before.
 
-If you find a security issue, please follow the guide [here](https://github.com/mintlayer/mintlayer-core/security/policy) to report it. 
+If you find a security issue, please follow the guide [here](https://github.com/mintlayer/mintlayer-core/security/policy) to report it.
 
 ## External contributors
 
 First and foremost, you should make sure you have [rust installed](https://www.rust-lang.org/tools/install). As a rule, we use the latest stable version of rust that is available; if this changes, we'll be sure to update this note.
 
-As an outside contributor, your first step will be to fork the repo and create your own copy. You can't push to our repo directly, so without doing this, it won't be possible to contribute any code. Your contributions should be put in a logically named branch in your fork. If you're not sure what I mean by that, take a look at the extant branches in our repo, and you'll see some examples. If you have several significant changes to make that don't logically fit together, then multiple branches and pull requests are the way to go. 
+As an outside contributor, your first step will be to fork the repo and create your own copy. You can't push to our repo directly, so without doing this, it won't be possible to contribute any code. Your contributions should be put in a logically named branch in your fork. If you're not sure what I mean by that, take a look at the extant branches in our repo, and you'll see some examples. If you have several significant changes to make that don't logically fit together, then multiple branches and pull requests are the way to go.
 
-As you make your changes, ensure the code is as clean as possible and well documented so that it's clear to us what you're up to when we review it and it is thoroughly tested. Make sure that the old tests still pass, as well as any tests you've added. We will only merge code with all the tests passing in CI. 
+As you make your changes, ensure the code is as clean as possible and well documented so that it's clear to us what you're up to when we review it and it is thoroughly tested. Make sure that the old tests still pass, as well as any tests you've added. We will only merge code with all the tests passing in CI.
 
 ## Internal contributors