Merge pull request microsoft#1896 from tyrielv/tyrielv/hydration-summary-warning-telemetry

Log hydration calculation errors to telemetry

Author: tyrielv

GVFS/GVFS.Common/GitStatusCache.cs

@@ -373,9 +373,10 @@ private void UpdateHydrationSummary()
                 }
                 else
                 {
+                    metadata["Exception"] = hydrationSummary.Error?.ToString();
                     this.context.Tracer.RelatedWarning(
                         metadata,
-                        $"{nameof(GitStatusCache)}{nameof(RebuildStatusCacheIfNeeded)}: hydration summary could not be calculdated.",
+                        $"{nameof(GitStatusCache)}{nameof(RebuildStatusCacheIfNeeded)}: hydration summary could not be calculated.",
                         Keywords.Telemetry);
                 }
             }

GVFS/GVFS.Common/HealthCalculator/EnlistmentHydrationSummary.cs

@@ -12,6 +12,8 @@ public class EnlistmentHydrationSummary
         public int TotalFileCount { get; private set; }
         public int HydratedFolderCount { get; private set; }
         public int TotalFolderCount { get; private set; }
+        public Exception Error { get; private set; } = null;
+
 
         public bool IsValid
         {
@@ -67,14 +69,15 @@ public static EnlistmentHydrationSummary CreateSummary(
                     TotalFolderCount = totalFolderCount,
                 };
             }
-            catch
+            catch (Exception e)
             {
                 return new EnlistmentHydrationSummary()
                 {
                     HydratedFileCount = -1,
                     HydratedFolderCount = -1,
                     TotalFileCount = -1,
                     TotalFolderCount = -1,
+                    Error = e,
                 };
             }
         }