Skip to content

Commit 9421d77

Browse files
committed
Prepare for utf8.decode() to return more precise Uint8List type
To avoid analyzer warnings when utf8.encode() will return the more precise Uint8List type, we use const Utf8Encoder().convert() which already returns Uint8List See dart-lang/sdk#52801
1 parent cd9ce66 commit 9421d77

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/web_ui/test/canvaskit/fragment_program_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ void testMain() {
186186
});
187187

188188
test('FragmentProgram can be created from JSON IPLR bundle', () {
189-
final Uint8List data = utf8.encode(kJsonIPLR) as Uint8List;
189+
final Uint8List data = const Utf8Encoder().convert(kJsonIPLR);
190190
final CkFragmentProgram program = CkFragmentProgram.fromBytes('test', data);
191191

192192
expect(program.effect, isNotNull);

lib/web_ui/test/engine/channel_buffers_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ void main() {
2323
}
2424

2525
ByteData _makeByteData(String str) {
26-
final Uint8List list = utf8.encode(str) as Uint8List;
26+
final Uint8List list = const Utf8Encoder().convert(str);
2727
final ByteBuffer buffer = list.buffer;
2828
return ByteData.view(buffer);
2929
}

testing/dart/channel_buffers_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'dart:ui' as ui;
1212
import 'package:litetest/litetest.dart';
1313

1414
ByteData _makeByteData(String str) {
15-
final Uint8List list = utf8.encode(str) as Uint8List;
15+
final Uint8List list = const Utf8Encoder().convert(str);
1616
final ByteBuffer buffer = list.buffer;
1717
return ByteData.view(buffer);
1818
}

0 commit comments

Comments
 (0)