Checking in bindgen generated file; do not run bindgen if file exists

Author: udesou

Makefile

@@ -3,6 +3,11 @@ MMTK_MOVING ?= 1
 MMTK_PLAN ?= Immix
 CURR_PATH := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
 
+# Disable some variables set inside Julia 
+# that may interfere with building the binding
+PKG_CONFIG_LIBDIR=
+PKG_CONFIG_PATH=
+
 # If the Julia directory doesn't exist throw an error
 # since we need it to generate the bindgen bindings
 ifeq (${JULIA_PATH},)
@@ -50,7 +55,6 @@ julia-debug:
 # Clean up the build artifacts
 clean:
 	@echo "Cleaning up build artifacts in $(JULIA_PATH) and $(MMTK_JULIA_DIR)";
-	@cd $(JULIA_PATH) && make clean
 	@cd $(MMTK_JULIA_DIR)mmtk && cargo clean
 
 .PHONY: release debug julia julia-debug clean

mmtk/build.rs

@@ -44,48 +44,50 @@ fn main() {
             .expect("failed to execute process");
     }
 
-    let bindings = bindgen::Builder::default()
-        .header(format!("{}/src/julia.h", julia_dir))
-        .header(format!("{}/src/julia_internal.h", julia_dir))
-        // Including the paths to depending .h files
-        .clang_arg("-I")
-        .clang_arg(format!("{}/mmtk/api", mmtk_dir))
-        .clang_arg("-I")
-        .clang_arg(format!("{}/src", julia_dir))
-        .clang_arg("-I")
-        .clang_arg(format!("{}/src/support", julia_dir))
-        .clang_arg("-I")
-        .clang_arg(format!("{}/usr/include", buildroot_dir))
-        // all types that we generate bindings from
-        .allowlist_item("jl_datatype_layout_t")
-        .allowlist_item("jl_ucontext_t")
-        .allowlist_item("jl_small_typeof_tags")
-        .allowlist_item("jl_*_tag")
-        .allowlist_item("jl_svec_t")
-        .allowlist_item("jl_module_t")
-        .allowlist_item("jl_task_t")
-        .allowlist_item("jl_datatype_t")
-        .allowlist_item("jl_weakref_t")
-        .allowlist_item("jl_binding_partition_t")
-        .allowlist_item("jl_bt_element_t")
-        .allowlist_item("jl_taggedvalue_t")
-        .allowlist_item("MMTkMutatorContext")
-        // --opaque-type MMTkMutatorContext
-        .opaque_type("MMTkMutatorContext")
-        // compile using c++
-        .clang_arg("-x")
-        .clang_arg("c++")
-        .clang_arg("-std=c++14")
-        // using MMTK types
-        .clang_arg("-DMMTK_GC")
-        // Finish the builder and generate the bindings.
-        .generate()
-        // Unwrap the Result and panic on failure.
-        .expect("Unable to generate bindings");
+    if !Path::new(format!("{}/mmtk/src/julia_types.rs", mmtk_dir).as_str()).exists() {
+        let bindings = bindgen::Builder::default()
+            .header(format!("{}/src/julia.h", julia_dir))
+            .header(format!("{}/src/julia_internal.h", julia_dir))
+            // Including the paths to depending .h files
+            .clang_arg("-I")
+            .clang_arg(format!("{}/mmtk/api", mmtk_dir))
+            .clang_arg("-I")
+            .clang_arg(format!("{}/src", julia_dir))
+            .clang_arg("-I")
+            .clang_arg(format!("{}/src/support", julia_dir))
+            .clang_arg("-I")
+            .clang_arg(format!("{}/usr/include", buildroot_dir))
+            // all types that we generate bindings from
+            .allowlist_item("jl_datatype_layout_t")
+            .allowlist_item("jl_ucontext_t")
+            .allowlist_item("jl_small_typeof_tags")
+            .allowlist_item("jl_*_tag")
+            .allowlist_item("jl_svec_t")
+            .allowlist_item("jl_module_t")
+            .allowlist_item("jl_task_t")
+            .allowlist_item("jl_datatype_t")
+            .allowlist_item("jl_weakref_t")
+            .allowlist_item("jl_binding_partition_t")
+            .allowlist_item("jl_bt_element_t")
+            .allowlist_item("jl_taggedvalue_t")
+            .allowlist_item("MMTkMutatorContext")
+            // --opaque-type MMTkMutatorContext
+            .opaque_type("MMTkMutatorContext")
+            // compile using c++
+            .clang_arg("-x")
+            .clang_arg("c++")
+            .clang_arg("-std=c++14")
+            // using MMTK types
+            .clang_arg("-DMMTK_GC")
+            // Finish the builder and generate the bindings.
+            .generate()
+            // Unwrap the Result and panic on failure.
+            .expect("Unable to generate bindings");
 
-    bindings
-        .write_to_file("src/julia_types.rs")
-        .expect("Couldn't write bindings!");
+        bindings
+            .write_to_file("src/julia_types.rs")
+            .expect("Couldn't write bindings!");
+    }
 
     built::write_built_file().expect("Failed to acquire build-time information");
 }