chore: enabled ESLint's no-unused-vars#5399
Merged
mark-wiemer merged 2 commits intomochajs:mainfrom Jul 12, 2025
Merged
Conversation
samuelhnrq
approved these changes
Jul 11, 2025
Contributor
samuelhnrq
left a comment
samuelhnrq
left a comment
There was a problem hiding this comment.
I was surprised to learn this was not enabled already.
mark-wiemer
approved these changes
Jul 12, 2025
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
It's been bugging me that we have a bunch of unused imports, parameters, and variables hanging around.
no-unused-varsis enabled in basically every linter preset out there, including neostandard (#5301) and ESLint's recommended (#5281).