Skip to content

Excessive warning statements printed out while running the regression #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adpaco-aws opened this issue Oct 20, 2021 · 4 comments
Closed
Labels
T-Good First Issue Good for newcomers

Comments

@adpaco-aws
Copy link
Contributor

adpaco-aws commented Oct 20, 2021

A large blob of warning statements is being printed out while running the regression. Looks like it is happening in all testing scripts.

@adpaco-aws adpaco-aws self-assigned this Oct 20, 2021
@adpaco-aws adpaco-aws removed their assignment Oct 21, 2021
@adpaco-aws adpaco-aws changed the title Hide warning statements printed out while running the regression Excessive warning statements printed out while running the regression Oct 21, 2021
@adpaco-aws
Copy link
Contributor Author

The Rust team has changed the way they treat warnings so they are printed by default. See the discussion and the change.

We are keeping this issue open until we clean all warnings.

@zhassan-aws
Copy link
Contributor

The warnings are specifically coming from these two:

  1. scripts/codegen-firecracker.sh
  2. src/test/rmc-multicrate/type-mismatch/run-mismatch-test.sh

@adpaco-aws
Copy link
Contributor Author

In my opinion, the long-term solution for this would be to figure out the type mismatch issue in #277. It points to an issue in the way we codegen slices. Other warnings (e.g., for concurrent features) are informative and it should be okay to have them printed during the regressions.

@celinval celinval added the T-Good First Issue Good for newcomers label Mar 23, 2022
@adpaco-aws
Copy link
Contributor Author

Closing because the long-term solution was merged earlier this year in #1205. Thanks, @celinval ! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants