#107 Update StdioClientTransport #436
Draft
+598
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class has been enhanced to monitor the standard error (stderr) stream, enabling the detection of fatal errors that should terminate the connection. Its internal threading model was refactored to use structured concurrency, ensuring that the separate coroutines for standard input, output, and error are properly supervised and cancelled together. The API was expanded with new constructors that accept an error source and a predicate for identifying fatal error lines. Furthermore, the helper was updated to expose functionality, supporting the processing of line-based text from the error stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StdioClientTransport class has been enhanced to monitor the standard error (stderr) stream, enabling the detection of fatal errors that should terminate the connection. Its internal threading model was refactored to use structured concurrency, ensuring that the separate coroutines for standard input, output, and error are properly supervised and cancelled together. The API was expanded with new constructors that accept an error source and a predicate for identifying fatal error lines. Furthermore, the helper was updated to expose functionality, supporting the processing of line-based text from the error stream.
Motivation and Context
#107 Handle errors in Stdio transport
How Has This Been Tested?
Unit/untegraiton tests
Breaking Changes
Types of changes
Checklist
Additional context