FIX-#2658: Move backend check in xgb to train/predict (#2659)

Signed-off-by: Alexey Prutskov <[email protected]>

Author: prutskov

.github/workflows/ci.yml

@@ -220,6 +220,8 @@ jobs:
           conda list
       - name: Install HDF5
         run: sudo apt update && sudo apt install -y libhdf5-dev
+      - shell: bash -l {0}
+        run: pytest modin/experimental/xgboost/test/test_default.py --backend=${{ matrix.backend }}
       - shell: bash -l {0}
         run: python -m pytest modin/test/backends/base/test_internals.py --backend=${{ matrix.backend }}
       - shell: bash -l {0}
@@ -368,6 +370,8 @@ jobs:
           conda list
       - name: Install HDF5
         run: sudo apt update && sudo apt install -y libhdf5-dev
+      - shell: bash -l {0}
+        run: pytest modin/experimental/xgboost/test/test_default.py
       - shell: bash -l {0}
         run: pytest modin/pandas/test/dataframe/test_binary.py
       - shell: bash -l {0}

.github/workflows/push.yml

@@ -61,6 +61,8 @@ jobs:
           conda list
       - name: Install HDF5
         run: sudo apt update && sudo apt install -y libhdf5-dev
+      - shell: bash -l {0}
+        run: pytest modin/experimental/xgboost/test/test_default.py --backend=${{ matrix.backend }}
       - shell: bash -l {0}
         run: pytest modin/pandas/test/dataframe/test_binary.py --backend=${{ matrix.backend }}
       - shell: bash -l {0}
@@ -154,6 +156,8 @@ jobs:
           conda list
       - name: Install HDF5
         run: sudo apt update && sudo apt install -y libhdf5-dev
+      - shell: bash -l {0}
+        run: pytest modin/experimental/xgboost/test/test_default.py
       - shell: bash -l {0}
         run: pytest modin/pandas/test/dataframe/test_binary.py
       - shell: bash -l {0}

environment-dev.yml

@@ -34,3 +34,5 @@ dependencies:
   - boto3
   - asv
   - ray-core >=1.0.0
+  - pip:
+      - xgboost >=1.3

modin/experimental/xgboost/test/__init__.py

@@ -0,0 +1,12 @@
+# Licensed to Modin Development Team under one or more contributor license agreements.
+# See the NOTICE file distributed with this work for additional information regarding
+# copyright ownership.  The Modin Development Team licenses this file to you under the
+# Apache License, Version 2.0 (the "License"); you may not use this file except in
+# compliance with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed under
+# the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
+# ANY KIND, either express or implied. See the License for the specific language
+# governing permissions and limitations under the License.

modin/experimental/xgboost/test/test_default.py

@@ -0,0 +1,30 @@
+# Licensed to Modin Development Team under one or more contributor license agreements.
+# See the NOTICE file distributed with this work for additional information regarding
+# copyright ownership.  The Modin Development Team licenses this file to you under the
+# Apache License, Version 2.0 (the "License"); you may not use this file except in
+# compliance with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed under
+# the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
+# ANY KIND, either express or implied. See the License for the specific language
+# governing permissions and limitations under the License.
+
+
+import pytest
+from modin.config import Engine
+
+import modin.experimental.xgboost as xgb
+
+
+@pytest.mark.skipif(
+    Engine.get() == "Ray",
+    reason="This test doesn't make sense on Ray backend.",
+)
+@pytest.mark.parametrize("func", ["train", "predict"])
+def test_backend(func):
+    try:
+        getattr(xgb, func)({}, xgb.ModinDMatrix(None, None))
+    except ValueError:
+        pass

modin/experimental/xgboost/xgboost.py

@@ -20,11 +20,6 @@
 
 from modin.config import Engine
 
-if Engine.get() == "Ray":
-    from .xgboost_ray import _train, _predict
-else:
-    raise ValueError("Current version supports only Ray engine as MODIN_ENGINE.")
-
 LOGGER = logging.getLogger("[modin.xgboost]")
 
 
@@ -99,6 +94,12 @@ def train(
                          'eval': {'logloss': ['0.480385', '0.357756']}}}
     """
     LOGGER.info("Training started")
+
+    if Engine.get() == "Ray":
+        from .xgboost_ray import _train
+    else:
+        raise ValueError("Current version supports only Ray engine.")
+
     result = _train(
         dtrain, nthread, evenly_data_distribution, params, *args, evals=evals, **kwargs
     )
@@ -137,6 +138,11 @@ def predict(
     """
     LOGGER.info("Prediction started")
 
+    if Engine.get() == "Ray":
+        from .xgboost_ray import _predict
+    else:
+        raise ValueError("Current version supports only Ray engine.")
+
     if isinstance(model, xgb.Booster):
         booster = model
     elif isinstance(model, dict):

requirements-dev.txt

@@ -27,3 +27,4 @@ pandas_gbq
 cloudpickle
 rpyc==4.1.5
 asv
+xgboost>=1.3