RUST-2310 Deprioritize servers in server selection for all topologies #1576
Conversation
There was a problem hiding this comment.
A lot of the changes in this file are just shuffling things around; the functional changes are based on this diff from the spec PR.
| topology_description: &'a TopologyDescription, | ||
| servers: &'a HashMap<ServerAddress, Arc<Server>>, | ||
| deprioritized: Option<&ServerAddress>, | ||
| deprioritized: &[&ServerAddress], |
There was a problem hiding this comment.
Made this a list in anticipation of CSOT and because the tests use lists of multiple addresses.
isabelatkinson
changed the title
abr-egn
left a comment
abr-egn
left a comment
There was a problem hiding this comment.
LGTM! Some very small questions, no need for a re-review.
| fn suitable_servers( | ||
| fn filter_servers_in_replica_set<'a>( | ||
| &self, | ||
| servers: impl Iterator<Item = &'a ServerDescription> + Clone, |
There was a problem hiding this comment.
Why not just &[&'a ServerDescription]?
There was a problem hiding this comment.
filter_servers_by_selection_criteria (which calls this) already has an iterator with the deprioritized servers filtered out, so accepting that directly allows us to avoid an intermediary structure
driver/src/client.rs
Outdated
| #[allow(unused_variables)] // we only use the operation_name for tracing. | ||
| operation_name: &str, | ||
| deprioritized: Option<&ServerAddress>, | ||
| deprioritized: Vec<&ServerAddress>, |
There was a problem hiding this comment.
Likewise, it doesn't seem like this needs to be owned?
|
not sure why but this is still requiring re-approval |
2 participants
RUST-2310