changes

Author: baileympearson

.eslintignore

@@ -2,5 +2,3 @@
 lib
 test/disabled
 !etc/docs
-
-test/explicit-resource-management

.eslintrc.json

@@ -6,13 +6,11 @@
   },
   "plugins": [
     "simple-import-sort",
-    "import",
     "@typescript-eslint",
     "prettier",
     "unused-imports",
     "tsdoc",
-    "mocha",
-    "github"
+    "mocha"
   ],
   "extends": [
     "eslint:recommended",
@@ -67,15 +65,17 @@
     ],
     "simple-import-sort/imports": "error",
     "simple-import-sort/exports": "error",
-    "import/first": "error",
-    "import/newline-after-import": "error",
-    "import/no-duplicates": "error",
     "strict": [
       "error",
       "global"
     ],
     "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-non-null-assertion": "error",
+    "@typescript-eslint/no-redundant-type-constituents": "off",
+    "@typescript-eslint/no-empty-function": "error",
+    "@typescript-eslint/no-require-imports": "off",
     "@typescript-eslint/require-await": "off",
+    "@typescript-eslint/no-unused-expressions": "off",
     "@typescript-eslint/consistent-type-imports": [
       "error",
       {
@@ -121,12 +121,8 @@
         "message": "Do not strictly check typeof undefined (NOTE: currently this rule only detects the usage of 'undefined' string literal so this could be a misfire)"
       }
     ],
-    "@typescript-eslint/no-unused-vars": [
-      "error",
-      {
-        "argsIgnorePattern": "^_"
-      }
-    ]
+    "@typescript-eslint/no-unused-vars": "error",
+    "no-duplicate-imports": "error"
   },
   "overrides": [
     {
@@ -168,6 +164,7 @@
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-this-alias": "off",
         "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/consistent-type-imports": "off",
         // Since we use ts-node we should always require the TS code
         // Also we have patches to apply to the mock server, so we should always import from there
         "no-restricted-modules": [
@@ -200,6 +197,15 @@
         "no-restricted-syntax": "off",
         "typescript-eslint/ban-ts-comment": "off",
         "no-restricted-imports": "off",
+        "@typescript-eslint/no-unused-vars": [
+          "error",
+          {
+            "argsIgnorePattern": "^_",
+            "caughtErrorsIgnorePattern": "^_",
+            "destructuredArrayIgnorePattern": "^_",
+            "varsIgnorePattern": "^_"
+          }
+        ],
         "@typescript-eslint/no-restricted-imports": [
           "error",
           {
@@ -235,12 +241,23 @@
         "@typescript-eslint/restrict-plus-operands": "off",
         "@typescript-eslint/restrict-template-expressions": "off",
         "@typescript-eslint/require-await": "off",
+        "@typescript-eslint/no-redundant-type-constituents": "off",
+        "@typescript-eslint/no-unused-expressions": "off",
+        "@typescript-eslint/no-explicit-any": "off",
         "no-return-await": "off",
         "@typescript-eslint/return-await": [
           "error",
           "always"
         ],
-        "github/no-then": "error",
+        "@typescript-eslint/no-unused-vars": [
+          "error",
+          {
+            "argsIgnorePattern": "^_",
+            "caughtErrorsIgnorePattern": "^_",
+            "destructuredArrayIgnorePattern": "^_",
+            "varsIgnorePattern": "^_"
+          }
+        ],
         "no-restricted-imports": [
           "error",
           {
@@ -263,7 +280,7 @@
         "tsdoc/syntax": "warn",
         "no-console": "off",
         "@typescript-eslint/no-explicit-any": "off",
-        "@typescript-eslint/no-unused-vars": "error",
+        "@typescript-eslint/no-unused-vars": "off",
         "@typescript-eslint/ban-ts-comment": "off",
         "@typescript-eslint/no-empty-function": "off"
       }
@@ -276,7 +293,18 @@
       ],
       "parser": "@typescript-eslint/parser",
       "rules": {
-        "unused-imports/no-unused-imports": "error"
+        "unused-imports/no-unused-imports": "error",
+        "@typescript-eslint/no-empty-object-type": "off",
+        "@typescript-eslint/no-unsafe-declaration-merging": "off",
+        "no-duplicate-imports": "off",
+        "@typescript-eslint/consistent-type-imports": [
+          "error",
+          {
+            "prefer": "type-imports",
+            "disallowTypeAnnotations": false,
+            "fixStyle": "separate-type-imports"
+          }
+        ]
       }
     }
   ]