9.2.2 - fix players unable to complete chargen, duplicated creature talents

close #2383

Author: moo-man

src/apps/chargen/char-gen.js

@@ -378,9 +378,11 @@ export default class CharGenWfrp4e extends FormApplication {
         localStorage.removeItem("wfrp4e-chargen")
       }
       else {
-        const payload =  {id : game.user.id, data : this.actor, options : {skipSpecialisationChoice : true, skipItems : true}}
-        let id = await SocketHandlers.call("createActor", payload, "GM");
-        let actor = game.actors.get(id);
+        let actorId = foundry.utils.randomID()
+        this.actor._id = actorId;
+        const payload =  {id : game.user.id, data : this.actor, options : {skipSpecialisationChoice : true, skipItems : true, keepId : true}}
+        await SocketHandlers.call("createActor", payload, "GM");
+        let actor = game.actors.get(actorId);
         await actor.createEmbeddedDocuments("Item", actorItems, {skipSpecialisationChoice : true})
         if (actor && actor.isOwner) 
         {

src/sheets/actor/creature-sheet.js

@@ -80,7 +80,14 @@ export default class ActorSheetWFRP4eCreature extends StandardWFRP4eActorSheet
 
         context.trained = this.actor.itemTags.skill.filter(i => i.advances.value > 0).sort(WFRP_Utility.nameSorter);
         context.includedTraits = this.actor.itemTags.trait.filter(i => i.included).sort(WFRP_Utility.nameSorter);
-    
+        context.talents = [];
+        for(let talent of context.items.talent)
+        {
+          if (!context.talents.find(existing => existing.name == talent.name))
+          {
+            context.talents.push(talent);
+          }
+        }
 
         context.overviewButtons = this.actor.items.contents.reduce((buttons, item) => {
           let add = [];

static/templates/sheets/actor/creature/creature-main.hbs

@@ -36,7 +36,7 @@
                 {{#if items.talent.length}}
                     <div class="overview-list">
                         <label class="list-label">{{localize "Talents"}}:</label>
-                        {{#each items.talent}}
+                        {{#each talents}}
                             <a data-action="overviewDropdown" class="context-menu-alt" data-click="right" data-uuid="{{this.uuid}}">{{this.name}} </a>
                             <a class="talents advances">{{this.Advances}}</a>
                             ,

system.json

@@ -2,7 +2,7 @@
   "id": "wfrp4e",
   "title": "Warhammer Fantasy Roleplay 4th Edition",
   "description": "A comprehensive system for running grim and perilous games of Warhammer Fantasy Roleplay in the Foundry VTT environment.",
-  "version": "9.2.1",
+  "version": "9.2.2",
   "authors" : [
     {
       "name": "Moo Man",
@@ -72,6 +72,6 @@
   },
   "socket": true,
   "manifest" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/latest/download/system.json",
-  "download" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/download/9.2.1/wfrp4e.zip",
+  "download" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/download/9.2.2/wfrp4e.zip",
   "url" : "https://github.com/moo-man/WFRP4e-FoundryVTT"
 }