-
Notifications
You must be signed in to change notification settings - Fork 3
GitHub importer uses group's name instead of login #248
Copy link
Copy link
Open
Description
We get an error when trying to import the model of a group which has a display name that differs from its login.
For example, the group Evref-BL has the login "Evref-BL" but the name "Evref - Berger-Levrault":
GET https://api.github.com/orgs/Evref-BL ->
{
"login": "Evref-BL",
"name": "Evref - Berger-Levrault"
}The importer tries to use the name when querying the API and we're hit with a 404 Not Found.
GithubModelImporter new
glhModel: GLHModel new;
importGroup: 'Evref-BL'.The issue happens when the name is given in GithubModelImporter>>#importRepositoriesOfGroup:.
However, it seems the login is not stored in the model at all. See the GLHGroup entity below:

Fix
I see three possibilities:
- GLHGroup's name becomes the login and we discard the display name
- GLHGroup's name becomes the login and we add a
displayNameattribute - GLHGroup's name stays the display name and we add a
loginattribute
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels