Skip to content

GitHub importer uses group's name instead of login #248

@Gabriel-Darbord

Description

@Gabriel-Darbord

We get an error when trying to import the model of a group which has a display name that differs from its login.
For example, the group Evref-BL has the login "Evref-BL" but the name "Evref - Berger-Levrault":
GET https://api.github.com/orgs/Evref-BL ->

{
  "login": "Evref-BL",
  "name": "Evref - Berger-Levrault"
}

The importer tries to use the name when querying the API and we're hit with a 404 Not Found.

GithubModelImporter new
    glhModel: GLHModel new;
    importGroup: 'Evref-BL'.

The issue happens when the name is given in GithubModelImporter>>#importRepositoriesOfGroup:.
However, it seems the login is not stored in the model at all. See the GLHGroup entity below:
Image

Fix

I see three possibilities:

  1. GLHGroup's name becomes the login and we discard the display name
  2. GLHGroup's name becomes the login and we add a displayName attribute
  3. GLHGroup's name stays the display name and we add a login attribute

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions