Fix issue where s3 thumbnails were shown as browser-compatible radiantearth/stac-browser#668

Author: m-mohr

src/reference.js

@@ -2,7 +2,6 @@ import { browserProtocols, toAbsolute } from './http.js';
 import { cogMediaTypes, geotiffMediaTypes, isMediaType } from "./mediatypes.js";
 import { hasText } from './utils.js';
 import STACObject from './object.js';
-import URI from 'urijs';
 import { browserImageTypes } from './mediatypes.js';
 
 /**
@@ -68,9 +67,9 @@ class STACReference extends STACObject {
     else if (!allowUndefined && typeof this.type === 'undefined') {
       return false;
     }
-    let uri = new URI(this.href);
-    let protocol = uri.protocol().toLowerCase();
-    let extension = uri.suffix().toLowerCase();
+    const uri = this.getAbsoluteUrl(false);
+    const protocol = uri.protocol().toLowerCase();
+    const extension = uri.suffix().toLowerCase();
     if (hasText(protocol) && !browserProtocols.includes(protocol)) {
       return false;
     }

src/stac.js

@@ -86,17 +86,17 @@ class STAC extends STACHypermedia {
     if (thumbnails.length === 0) {
       thumbnails = this.getLinks().filter(link => link.isPreview());
     }
-    if (browserOnly) {
-      // Remove all images that can't be displayed in a browser
-      thumbnails = thumbnails.filter(img => img.canBrowserDisplayImage());
-    }
     // Some old catalogs use just a asset key
     if (thumbnails.length === 0) {
       const thumbnail = this.getAsset("thumbnail");
       if (thumbnail) {
         thumbnails.push(thumbnail);
       }
     }
+    if (browserOnly) {
+      // Remove all images that can't be displayed in a browser
+      thumbnails = thumbnails.filter(img => img.canBrowserDisplayImage());
+    }
     if (prefer && thumbnails.length > 1) {
       // Prefer one role over the other.
       // The two step approach with two filters ensures the same sort bevahiour across all browsers: