Skip to content

refactor(liquidate): rename intermediary var #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Rubilmax
Copy link
Collaborator

No description provided.

@Rubilmax Rubilmax marked this pull request as ready for review December 12, 2023 09:31
MerlinEgalite
MerlinEgalite previously approved these changes Dec 12, 2023
Jean-Grimal
Jean-Grimal previously approved these changes Dec 12, 2023
Base automatically changed from fix/liquidation to post-cantina December 12, 2023 12:19
@MathisGD MathisGD dismissed stale reviews from Jean-Grimal and MerlinEgalite December 12, 2023 12:19

The base branch was changed.

Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No veto but to me the current version is great, it's ok to have a variable temp in this particular case

@Rubilmax Rubilmax merged commit 64dac54 into post-cantina Dec 18, 2023
@Rubilmax Rubilmax deleted the refactor/liquidation-stack branch December 18, 2023 10:47
@MathisGD MathisGD mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants