Bug 1663596 [wpt PR 25430] - [blink][web_tests] document-write tests cleanup, a=testonly

Automatic update from web-platform-tests
[blink][web_tests] document-write tests cleanup

- Add better assertion failure messages
- Use better content for document.write

The tests assume that the ignore-destructive-writes counter is only
incremented during the synchronous part of module evaluation (see
whatwg/html#4352 (comment)).

This also fixes document-write/module-delayed.html which accidentally
had wrong test expectations checked in that made it pass.

Bug: 1127215
Bug: 1022182
Bug: v8:9344
Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#807384}

--

wpt-commits: 05285a54f6369d56c51df2dc12e05730dd297d81
wpt-pr: 25430

Author: camillobruni

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html

@@ -10,16 +10,17 @@
   const iframe = document.createElement("iframe");
 
   iframe.onerror = t.unreached_func("Error loading iframe");
+
   let onLoadWasCalled = false;
   iframe.onload = t.step_func(() => {
+    onLoadWasCalled = true;
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
     // Don't call the event handler another time after document.write.
     iframe.onload = null;
-    onLoadWasCalled = true;
   });
   document.addEventListener("documentWriteDone", t.step_func_done(() => {
-    assert_equals(iframe.onload, null);
-    assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
+    assert_true(onLoadWasCalled, "onload must be called");
+    assert_equals(iframe.contentDocument.body.textContent, "document.write body contents\n");
   }));
 
   iframe.src = "module-delayed-iframe.html";

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-dynamic-import.html

@@ -8,14 +8,16 @@
   const iframe = document.createElement("iframe");
 
   iframe.onerror = t.unreached_func("Error loading iframe");
+
   let onLoadWasCalled = false;
   iframe.onload = t.step_func(() => {
+    onLoadWasCalled = true;
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
+    // Don't call the event handler another time after document.write.
     iframe.onload = null;
-    onLoadWasCalled = true;
   });
   document.addEventListener("documentWriteDone", t.step_func_done(() => {
-    assert_true(onLoadWasCalled);
+    assert_true(onLoadWasCalled, "onload must be called");
     assert_equals(iframe.contentDocument.body.textContent, "document.write body contents\n");
   }));
 

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html

@@ -8,16 +8,17 @@
   // Expose {test} in the iframe for using the step_timeout helper.
   document.test = t;
   const iframe = document.createElement("iframe");
-
   iframe.onerror = t.unreached_func("Error loading iframe");
+
   let onLoadWasCalled = false;
   iframe.onload = t.step_func(() => {
+    onLoadWasCalled = true;
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
+    // Don't call the event handler another time after document.write.
     iframe.onload = null;
-    onLoadWasCalled = true;
   });
   document.addEventListener("documentWriteDone", t.step_func_done(() => {
-    assert_true(onLoadWasCalled);
+    assert_true(onLoadWasCalled, "onload must be called");
     assert_equals(iframe.contentDocument.body.textContent, "document.write body contents\n");
   }));
 

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-static-import.html

@@ -6,15 +6,16 @@
 <script>
 async_test(t => {
   const iframe = document.createElement("iframe");
+
   iframe.onerror = t.unreached_func("Error loading iframe");
 
   let testEndWasCalled = false;
   document.addEventListener("documentWriteDone", t.step_func(() => {
-    assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
     testEndWasCalled = true;
+    assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
   }));
   iframe.onload = t.step_func_done(() => {
-    assert_true(testEndWasCalled);
+    assert_true(testEndWasCalled, "onload must be called");
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
   });
 

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed-iframe.html

@@ -4,7 +4,7 @@
     resolve => window.parent.document.test.step_timeout(resolve, 0));
 
 delay.then(() => {
-  document.write("FAIL");
+  document.write("document.write body contents\n");
   document.close();
   window.parent.document.dispatchEvent(new CustomEvent("documentWriteDone"));
 });

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html

@@ -15,13 +15,13 @@
 
   let onLoadWasCalled = false;
   iframe.onload = t.step_func(() => {
+    onLoadWasCalled = true;
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
     iframe.onload = null;
-    onLoadWasCalled = true;
   });
   document.addEventListener("documentWriteDone", t.step_func_done(() => {
-    assert_true(onLoadWasCalled);
-    assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
+    assert_true(onLoadWasCalled, "onload must be called");
+    assert_equals(iframe.contentDocument.body.textContent, "document.write body contents\n");
   }));
 
   iframe.src = "module-tla-delayed-iframe.html";

testing/web-platform/tests/html/webappapis/dynamic-markup-insertion/document-write/module-tla-immediate-promise.html

@@ -9,16 +9,17 @@
   document.test = t;
 
   const iframe = document.createElement("iframe");
-
   iframe.onerror = t.unreached_func("Error loading iframe");
+
   let onLoadWasCalled = false;
   iframe.onload = t.step_func(() => {
+    onLoadWasCalled = true;
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
+    // Don't call the event handler another time after document.write.
     iframe.onload = null;
-    onLoadWasCalled = true;
   });
   document.addEventListener("documentWriteDone", t.step_func_done(() => {
-    assert_true(onLoadWasCalled);
+    assert_false(onLoadWasCalled, "onload must not be called yet");
     assert_equals(iframe.contentDocument.body.textContent, "Initial body contents\n");
   }));