Skip to content

Commit 9e23a4c

Browse files
authored
fix: Replace AMO API v3 with v4 (#2121)
Only src/program.js needs to be changed, but I replaced all instances of v3 with v4 to minimize confusion.
1 parent 02e5405 commit 9e23a4c

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ so as not to disturb any real `addons.mozilla.org` data.
312312

313313
````
314314
web-ext sign --api-key user:123 --api-secret abc1234 \
315-
--api-url-prefix https://addons-dev.allizom.org/api/v3
315+
--api-url-prefix https://addons-dev.allizom.org/api/v4
316316
````
317317
* Signed add-ons created with the development API are hard to install into
318318
Firefox. If you need to test installation of add-ons (you probably don't)

src/program.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ Example: $0 --help run.
527527
},
528528
'api-url-prefix': {
529529
describe: 'Signing API URL prefix',
530-
default: 'https://addons.mozilla.org/api/v3',
530+
default: 'https://addons.mozilla.org/api/v4',
531531
demandOption: true,
532532
type: 'string',
533533
},

tests/functional/test.cli.sign.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('web-ext sign', () => {
5454
() => withTempAddonDir({addonPath: minimalAddonPath}, (srcDir, tmpDir) => {
5555
const argv = [
5656
'sign', '--verbose',
57-
'--api-url-prefix', 'http://localhost:8989/fake/api/v3',
57+
'--api-url-prefix', 'http://localhost:8989/fake/api/v4',
5858
'--api-key', 'FAKEAPIKEY', '--api-secret', 'FAKEAPISECRET',
5959
'--source-dir', srcDir,
6060
];
@@ -85,7 +85,7 @@ describe('web-ext sign', () => {
8585
JSON.stringify({
8686
webExt: {
8787
sign: {
88-
apiUrlPrefix: 'http://localhost:8989/fake/api/v3',
88+
apiUrlPrefix: 'http://localhost:8989/fake/api/v4',
8989
},
9090
sourceDir: srcDir,
9191
},

tests/unit/test-cmd/test.sign.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('sign', () => {
2929
const signingConfig = {
3030
apiKey: 'AMO JWT issuer',
3131
apiSecret: 'AMO JWT secret',
32-
apiUrlPrefix: 'http://not-the-real-amo.com/api/v3',
32+
apiUrlPrefix: 'http://not-the-real-amo.com/api/v4',
3333
apiProxy: 'http://yourproxy:6000',
3434
timeout: 999,
3535
};

0 commit comments

Comments
 (0)