Rcpp::stop() in exported wrappers only

Exported functions (thin wrappers) use Rcpp::stop() for input
validation — the exception is caught immediately by BEGIN_RCPP/END_RCPP
in the generated RcppExports wrapper.

Implementation functions retain Rf_error() for defensive guards that
should never be reached if wrappers validate correctly (LCOV_EXCL,

This pattern avoids C++ exception unwinding through complex stack frames,
which can cause std::terminate() on ARM.

Revert "Rf_error →Rcpp:stop()"

This reverts commit b20e03e.

Test R-level guards instead of C++ error paths (ARM safety)

Author: ms609

src/day_1985.cpp

@@ -96,7 +96,7 @@ double calc_consensus_info(const List &trees, const LogicalVector &phylo,
 
   std::vector<ClusterTable> tables;
   if (std::size_t(n_trees) > tables.max_size()) {
-    Rcpp::stop("Not enough memory available to compute consensus of so many trees"); // LCOV_EXCL_LINE
+    Rf_error("Not enough memory available to compute consensus of so many trees"); // LCOV_EXCL_LINE
   }
 
   tables.reserve(n_trees);

src/hpart.cpp

@@ -126,7 +126,7 @@ size_t build_node_from_list(const RObject& node,
   if (Rf_isInteger(node) || Rf_isReal(node)) {
     const IntegerVector leaf_vec(node);
     if (leaf_vec.size() != 1) {
-      Rcpp::stop("List must only contain integers, not vectors of integers");   // #nocov
+      Rf_error("List must only contain integers, not vectors of integers");   // #nocov
     }
     const int leaf_label = leaf_vec[0];         // 1-based R leaf label
     const size_t leaf_idx = leaf_label - 1;     // 0-based label for HNode
@@ -172,7 +172,7 @@ size_t build_node_from_list(const RObject& node,
   }
 
   // Invalid node type
-  Rcpp::stop("Invalid node type");                                              // #nocov
+  Rf_error("Invalid node type");                                              // #nocov
 }
 
 

src/hpart_relabel.cpp

@@ -13,7 +13,7 @@ void recompute_bitsets_postorder(TreeDist::HPart &hpart, const size_t node_idx,
   if (node.children.empty()) {
     // Leaf node
     if (node.leaf_count != 1) {
-      Rcpp::stop("Leaf node has leaf_count != 1");                              // #nocov
+      Rf_error("Leaf node has leaf_count != 1");                              // #nocov
     }
     int new_index = mapping[node.label]; // mapping is 0-based
     node.label = new_index;

src/information.h

@@ -49,7 +49,7 @@ __attribute__((constructor))
 inline double split_phylo_info(const int32 n_in, const int32 *n_tip,
                                const double p) {
   if (*n_tip > CT_MAX_LEAVES) {
-    Rcpp::stop("This many leaves are not yet supported.");
+    Rf_error("This many leaves are not yet supported.");
   }
   const int32 n_out = *n_tip - n_in;
   assert(p > 0);
@@ -75,7 +75,7 @@ inline double split_phylo_info(const int32 n_in, const int32 *n_tip,
 inline double split_clust_info(const int32 n_in, const int32 *n_tip,
                                const double p) {
   if (*n_tip > CT_MAX_LEAVES) {
-    Rcpp::stop("This many leaves are not yet supported.");
+    Rf_error("This many leaves are not yet supported.");
   }
   const int32 n_out = *n_tip - n_in;
   assert(p > 0);

src/nni_distance.cpp

@@ -226,16 +226,7 @@ grf_match nni_rf_matching (
 
     ASSERT(n_splits > 0);
     ASSERT(n_tips > 3);
-    if (n_tips > NNI_MAX_TIPS) {
-      Rcpp::stop("Cannot calculate NNI distance for trees with so many tips.");
-    }
-    
-    // #nocov start
-    if (static_cast<int64_t>(n_splits) * static_cast<int64_t>(n_bins) >
-          static_cast<int64_t>(std::numeric_limits<int32_t>::max())) {
-      Rcpp::stop("Cannot calculate NNI distance for trees with so many splits.");
-    }
-    // #nocov end
+    ASSERT(n_tips <= NNI_MAX_TIPS); // Validated by exported wrapper
 
     const int32_t last_bin = n_bins - 1;
     const int32_t unset_tips = (n_tips % SL_BIN_SIZE) ? 
@@ -317,7 +308,7 @@ IntegerVector cpp_nni_distance(const IntegerMatrix& edge1,
 
   if (n_edge != int32_t(edge2.nrow())) {
     Rcpp::stop("Both trees must have the same number of edges. "
-             "Is one rooted and the other unrooted?");
+               "Is one rooted and the other unrooted?");
   }
 
   if (n_tip < 4) {

src/spr.cpp

@@ -119,7 +119,7 @@ IntegerVector confusion(const RawMatrix& x, const RawMatrix& y) {
 
 IntegerMatrix reverse (const IntegerMatrix x) {
   if (double(x.nrow()) > double(std::numeric_limits<intx>::max())) {
-    Rcpp::stop("This many edges are not (yet) supported.");
+    Rf_error("This many edges are not (yet) supported."); // impl guard; wrapper validates
   }
   const intx n_edge = intx(x.nrow());
   ASSERT(n_edge % 2 == 0); // Tree is binary

src/tree_distances.cpp

@@ -29,7 +29,7 @@ namespace TreeDist {
 
   void check_ntip(const double n) {
     if (n > static_cast<double>(std::numeric_limits<int16>::max())) {
-      Rf_error("This many tips are not (yet) supported."); // not Rcpp::stop: ARM safety
+      Rcpp::stop("This many tips are not (yet) supported.");
     }
   }
 
@@ -602,14 +602,11 @@ inline List shared_phylo (const RawMatrix &x, const RawMatrix &y,
                       _["matching"] = final_matching);
 }
 
-// Input validation: Rf_error (longjmp) instead of Rcpp::stop (C++ exception)
-// for ARM compatibility.  R callers should validate before reaching C++.
-
 // [[Rcpp::export]]
 List cpp_robinson_foulds_distance(const RawMatrix &x, const RawMatrix &y,
                                   const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   return robinson_foulds_distance(x, y, static_cast<int32>(nTip[0]));
 }
@@ -618,7 +615,7 @@ List cpp_robinson_foulds_distance(const RawMatrix &x, const RawMatrix &y,
 List cpp_robinson_foulds_info(const RawMatrix &x, const RawMatrix &y,
                               const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);
@@ -629,7 +626,7 @@ List cpp_robinson_foulds_info(const RawMatrix &x, const RawMatrix &y,
 List cpp_matching_split_distance(const RawMatrix &x, const RawMatrix &y,
                                  const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);
@@ -641,7 +638,7 @@ List cpp_jaccard_similarity(const RawMatrix &x, const RawMatrix &y,
                             const IntegerVector &nTip, const NumericVector &k,
                             const LogicalVector &allowConflict) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);
@@ -652,7 +649,7 @@ List cpp_jaccard_similarity(const RawMatrix &x, const RawMatrix &y,
 List cpp_msi_distance(const RawMatrix &x, const RawMatrix &y,
                       const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);
@@ -663,7 +660,7 @@ List cpp_msi_distance(const RawMatrix &x, const RawMatrix &y,
 List cpp_mutual_clustering(const RawMatrix &x, const RawMatrix &y,
                            const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);
@@ -674,7 +671,7 @@ List cpp_mutual_clustering(const RawMatrix &x, const RawMatrix &y,
 List cpp_shared_phylo(const RawMatrix &x, const RawMatrix &y,
                       const IntegerVector &nTip) {
   if (x.cols() != y.cols()) {
-    Rf_error("Input splits must address same number of tips.");
+    Rcpp::stop("Input splits must address same number of tips.");
   }
   const int32 n_tip = static_cast<int32>(nTip[0]);
   TreeDist::check_ntip(n_tip);