Tests: Add test cases discovered from mutation testing

Thanks https://github.com/sixty-north/cosmic-ray/ !

Author: msiemens

tests/test_middlewares.py

@@ -46,6 +46,20 @@ def test_caching_write_many(storage):
 
 
 def test_caching_flush(storage):
+    # Write contents
+    for _ in range(CachingMiddleware.WRITE_CACHE_SIZE - 1):
+        storage.write(element)
+
+    # Not yet flushed...
+    assert storage.memory is None
+
+    storage.write(element)
+
+    # Verify contents: Cache should be emptied and written to storage
+    assert storage.memory
+
+
+def test_caching_flush_manually(storage):
     # Write contents
     storage.write(element)
 

tests/test_queries.py

@@ -21,6 +21,7 @@ def test_eq():
 
 def test_ne():
     query = Query().value != 1
+    assert query({'value': 0})
     assert query({'value': 2})
     assert not query({'value': 1})
     assert hash(query)
@@ -35,6 +36,7 @@ def test_lt():
     query = Query().value < 1
     assert query({'value': 0})
     assert not query({'value': 1})
+    assert not query({'value': 2})
     assert hash(query)
 
 

tests/test_storages.py

@@ -87,6 +87,9 @@ def test_create_dirs():
             db_file = os.path.join(db_dir, 'db.json')
             break
 
+    with pytest.raises(OSError):
+        JSONStorage(db_file)
+
     JSONStorage(db_file, create_dirs=True).close()
     assert os.path.exists(db_file)
 
@@ -130,3 +133,22 @@ class MyStorage(Storage):
 
     with pytest.raises(TypeError):
         MyStorage()
+
+
+def test_custom_with_exception():
+    class MyStorage(Storage):
+        def read(self):
+            pass
+
+        def write(self, data):
+            pass
+
+        def __init__(self):
+            raise ValueError()
+
+        def close(self):
+            raise RuntimeError()
+
+    with pytest.raises(ValueError):
+        with TinyDB(storage=MyStorage) as db:
+            pass

tests/test_tinydb.py

@@ -435,10 +435,14 @@ def test_non_default_table():
     assert set(['non-default']) == db.tables()
 
     db.purge_tables()
+    default_table = TinyDB.DEFAULT_TABLE
+
     TinyDB.DEFAULT_TABLE = 'non-default'
     db = TinyDB(storage=MemoryStorage)
     assert set(['non-default']) == db.tables()
 
+    TinyDB.DEFAULT_TABLE = default_table
+
 
 def test_purge_table():
     db = TinyDB(storage=MemoryStorage)
@@ -454,6 +458,7 @@ def test_purge_table():
 
     db.purge_table(table_name)
     assert set([TinyDB.DEFAULT_TABLE]) == db.tables()
+    assert table_name not in db._table_cache
 
     db.purge_table('non-existent-table-name')
     assert set([TinyDB.DEFAULT_TABLE]) == db.tables()
@@ -481,9 +486,13 @@ def test_query_cache():
 
     results = db.search(query)
     assert len(results) == 1
-    # Now, modify the result ist
-    results.extend([1])
 
+    # Modify the db instance to not return any results when
+    # bypassing the query cache
+    db._table_cache[TinyDB.DEFAULT_TABLE]._read = lambda: {}
+
+    # Make sure we got an independent copy of the result list
+    results.extend([1])
     assert db.search(query) == [{'name': 'foo', 'value': 42}]
 
 

tinydb/database.py

@@ -79,8 +79,6 @@ def __init__(self, *args, **kwargs):
         table = kwargs.pop('default_table', self.DEFAULT_TABLE)
 
         # Prepare the storage
-        self._opened = False
-
         #: :type: Storage
         self._storage = storage(*args, **kwargs)
 
@@ -157,7 +155,7 @@ def __enter__(self):
         return self
 
     def __exit__(self, *args):
-        if self._opened is True:
+        if self._opened:
             self.close()
 
     def __getattr__(self, name):

tinydb/storages.py

@@ -15,13 +15,14 @@
     import json
 
 
-def touch(fname, times=None, create_dirs=False):
+def touch(fname, create_dirs):
     if create_dirs:
         base_dir = os.path.dirname(fname)
         if not os.path.exists(base_dir):
             os.makedirs(base_dir)
+
     with open(fname, 'a'):
-        os.utime(fname, times)
+        os.utime(fname, None)
 
 
 class Storage(with_metaclass(ABCMeta, object)):