Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Windows installer not cryptographically signed. #361

Closed
fake-name opened this issue Jun 19, 2015 · 3 comments
Closed

Windows installer not cryptographically signed. #361

fake-name opened this issue Jun 19, 2015 · 3 comments

Comments

@fake-name
Copy link

The installer executable available from the main msysgit webpage is unsigned, and it is therefore impossible to verify the integrity of the installer. This is just flat out bad.

untitled

All linux packages are signed and verified in basically every distribution, and windows has facilities for doing the same. There is no reason to /not/ sign the binaries, particularly when they are apparently release binaries (it says "preview", but there does not appear to be a non-preview version).

@dscho
Copy link
Member

dscho commented Jun 19, 2015

You will find that the recent release candidates of Git for Windows 2.x are signed. Since version 2.x will supersede version 1.x, I hope you agree that it is better to focus on 2.x than to release a new 1.x version just to release signed installers.

(it says "preview", but there does not appear to be a non-preview version)

There is indeed no official release of Git for Windows yet.

@dscho dscho closed this as completed Jun 19, 2015
@fake-name
Copy link
Author

Well, in that case, you should probably point https://msysgit.github.io/ to the new installer. Lots of 3-rd party installers link to that page for "here is where you get git".

@dscho
Copy link
Member

dscho commented Jun 19, 2015

Git for Windows 2.x is not officially released, either. So redirecting as you suggested would be premature. But yes, we will do that eventually: git-for-windows#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants