Skip to content

Commit b864119

Browse files
sharonyu-115Shuang Yu
andauthored
[megatron] Add TIS support to megatron backend (verl-project#3513)
### What does this PR do? Add the TIS support from verl-project#2953 to megatron actor ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) Co-authored-by: Shuang Yu <shuangy@shuangy-mlt.client.nvidia.com>
1 parent 0bc4d1b commit b864119

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

verl/workers/actor/megatron_actor.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,13 @@ def make_minibatch_iterator(self, data: DataProto) -> Iterable[DataProto]:
288288
]
289289
if self.config.use_kl_loss:
290290
select_keys.append("ref_log_prob")
291+
if self.config.tis_imp_ratio_cap > 0:
292+
assert "rollout_log_probs" in data.batch.keys(), (
293+
"Truncated Importance Sampling (TIS) requires to configure "
294+
"`actor_rollout_ref.rollout.calculate_log_probs=True` "
295+
"and is not currently supported in Server mode (agent loop)."
296+
)
297+
select_keys.append("rollout_log_probs")
291298
self.has_multi_modal_inputs = "multi_modal_inputs" in data.non_tensor_batch.keys()
292299
if self.has_multi_modal_inputs:
293300
data = data.select(select_keys, ["multi_modal_inputs"])
@@ -309,6 +316,7 @@ def compute_ppo_loss(self, model_output, data):
309316
response_mask = data["response_mask"].to(bool)
310317
# compute policy loss
311318
old_log_prob = data["old_log_probs"]
319+
rollout_log_probs = data["rollout_log_probs"] if self.config.tis_imp_ratio_cap > 0 else None
312320
advantages = data["advantages"]
313321

314322
loss_agg_mode = self.config.loss_agg_mode
@@ -323,6 +331,7 @@ def compute_ppo_loss(self, model_output, data):
323331
response_mask=response_mask,
324332
loss_agg_mode=loss_agg_mode,
325333
config=self.config,
334+
rollout_log_probs=rollout_log_probs,
326335
)
327336

328337
metrics.update(

0 commit comments

Comments
 (0)