[RadioGroup] Support defaultValue in uncontrolled mode #14092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
reviewed
Jan 5, 2019
joshwooding
reviewed
Jan 5, 2019
Member
There was a problem hiding this comment.
@Slessi You are right, we should be supporting the defaultValue property! Given the component root element is a <div> element, I think that we should:
- document this new supported property
- destructure it in the render method so it doesn't leak to the child.
This change makes me think of the react-final-form integration with Material-UI.
People can either provide the RadioGroup as a form field component or provide each Radio (the encouraged approach).
oliviertassinari
added
type: new feature
oliviertassinari
approved these changes
Jan 5, 2019
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13915