Skip to content

Commit 3994bcc

Browse files
[core] Remove usage of deprecated .keyCode (#22569)
1 parent ad558cb commit 3994bcc

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

docs/src/modules/components/AppSearch.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,8 @@ export default function AppSearch() {
123123

124124
React.useEffect(() => {
125125
const handleKeyDown = (nativeEvent) => {
126-
// Use nativeEvent.keyCode to support IE 11
127126
if (
128-
[
129-
191, // '/'
130-
83, // 's'
131-
].indexOf(nativeEvent.keyCode) !== -1 &&
127+
['/', 's'].indexOf(nativeEvent.key) !== -1 &&
132128
document.activeElement.nodeName === 'BODY' &&
133129
document.activeElement !== inputRef.current
134130
) {

packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,7 @@ function Unstable_TrapFocus(props) {
151151
};
152152

153153
const loopFocus = (nativeEvent) => {
154-
// 9 = Tab
155-
if (disableEnforceFocus || !isEnabled() || nativeEvent.keyCode !== 9) {
154+
if (disableEnforceFocus || !isEnabled() || nativeEvent.key !== 'Tab') {
156155
return;
157156
}
158157

packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,17 +106,17 @@ describe('<TrapFocus />', () => {
106106
);
107107

108108
fireEvent.keyDown(screen.getByTestId('modal'), {
109-
keyCode: 13, // Enter
109+
key: 'Enter',
110110
});
111111
fireEvent.keyDown(screen.getByTestId('modal'), {
112-
keyCode: 9, // Tab
112+
key: 'Tab',
113113
});
114114

115115
expect(document.querySelector('[data-test="sentinelStart"]')).toHaveFocus();
116116

117117
initialFocus.focus();
118118
fireEvent.keyDown(screen.getByTestId('modal'), {
119-
keyCode: 9, // Tab
119+
key: 'Tab',
120120
shiftKey: true,
121121
});
122122

0 commit comments

Comments
 (0)