Skip to content

Commit d8d290b

Browse files
authored
[pickers] Remove redundant aria-hidden (#26014)
1 parent 16e5d03 commit d8d290b

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

packages/material-ui-lab/src/DesktopDateRangePicker/DesktopDateRangePicker.test.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ describe('<DesktopDateRangePicker />', () => {
176176
expect(getAllByMuiTest('DateRangeHighlight')).to.have.length(31);
177177
});
178178

179-
it('selects the range from the next month', () => {
179+
it('selects the range from the next month', function test() {
180180
const onChangeMock = spy();
181181
render(
182182
<DesktopDateRangePicker
@@ -188,9 +188,12 @@ describe('<DesktopDateRangePicker />', () => {
188188
);
189189

190190
fireEvent.click(screen.getByLabelText('Jan 1, 2019'));
191-
fireEvent.click(
192-
screen.getByLabelText('Next month', { selector: ':not([aria-hidden="true"])' }),
193-
);
191+
// FIXME use `getByRole(role, {hidden: false})` and skip JSDOM once this suite can run in JSDOM
192+
const [visibleButton] = screen.getAllByRole('button', {
193+
hidden: true,
194+
name: 'Next month',
195+
});
196+
fireEvent.click(visibleButton);
194197
fireEvent.click(screen.getByLabelText('Mar 19, 2019'));
195198

196199
expect(onChangeMock.callCount).to.equal(2);

packages/material-ui-lab/src/PickersDay/PickersDay.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ const PickersDay = React.forwardRef(function PickersDay<TDate>(
260260
);
261261

262262
if (outsideCurrentMonth && !showDaysOutsideCurrentMonth) {
263-
return <div aria-hidden className={clsx(dayClassName, classes.hiddenDaySpacingFiller)} />;
263+
return <div className={clsx(dayClassName, classes.hiddenDaySpacingFiller)} />;
264264
}
265265

266266
return (

packages/material-ui-lab/src/internal/pickers/PickersArrowSwitcher.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ const PickersArrowSwitcher = React.forwardRef(function PickersArrowSwitcher(
9696
<div className={clsx(classes.root, className)} ref={ref} {...other}>
9797
<LeftArrowButton
9898
size="small"
99-
aria-hidden={isLeftHidden}
10099
aria-label={leftArrowButtonText}
101100
title={leftArrowButtonText}
102101
disabled={isLeftDisabled}
@@ -118,7 +117,6 @@ const PickersArrowSwitcher = React.forwardRef(function PickersArrowSwitcher(
118117
)}
119118
<RightArrowButton
120119
size="small"
121-
aria-hidden={isRightHidden}
122120
aria-label={rightArrowButtonText}
123121
title={rightArrowButtonText}
124122
edge="start"

0 commit comments

Comments
 (0)