Skip to content

Output of multiformats/legacy should be an interface-ipld-format #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
achingbrain opened this issue Mar 15, 2021 · 3 comments · Fixed by #77
Closed

Output of multiformats/legacy should be an interface-ipld-format #67

achingbrain opened this issue Mar 15, 2021 · 3 comments · Fixed by #77

Comments

@achingbrain
Copy link
Member

ipld/interface-ipld-format recently had types added - the return value from multiformats/legacy should be compatible with that type.

Right now js-IPFS expects IPLD formats to be of type https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core-types/src/ipld/format.ts but these aren't the same as ipld/interface-ipld-format. The next js-IPFS release will expect ipld/interface-ipld-format so that's the type multiformats/legacy should return.

Refs: ipfs/js-ipfs#3586

@achingbrain
Copy link
Member Author

Short answer, use blockcodec-to-ipld-format instead

@rvagg
Copy link
Member

rvagg commented May 5, 2021

@achingbrain should we get rid of the /legacy export from here entirely and document the new lib since you've basically solved all that there?

@rvagg
Copy link
Member

rvagg commented May 5, 2021

(working backward through my notifications, ignore my comment as I now see #77!)

@rvagg rvagg closed this as completed in #77 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants