Skip to content

Commit 7fb7f2c

Browse files
committed
Revert "Disabled GO111MODULE environment variable on CI systems."
This reverts commit d5b8540. It turns out that this variable is somewhat necessary, even with Go 1.12, because if a CI system clones Mutagen into $GOPATH/src (which happens on Travis), and GO111MODULE is unset or set to "auto" (which is the default and also explicitly done on Travis), then module support is disabled. Until GO111MODULE=on is the default, let's continue to set this, even on AppVeyor (where it may not be necessary since we don't clone into %GOPATH%/src). Looking forward, it looks like Go 1.13 may not make GO111MODULE=on the default after all, but it looks like it may remove the disable-if-in-$GOPATH/src behavior, so we may be able to get rid of this setting at that point. See golang/go#31857 for more information.
1 parent d5b8540 commit 7fb7f2c

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ matrix:
77
- os: osx
88
osx_image: xcode9.4
99
env:
10+
- GO111MODULE=on
1011
- MUTAGEN_TEST_END_TO_END=full
1112
- MUTAGEN_TEST_SSH=true
1213
- os: linux
1314
env:
15+
- GO111MODULE=on
1416
- MUTAGEN_TEST_END_TO_END=full
1517
- MUTAGEN_TEST_SSH=true
1618
- MUTAGEN_TEST_DOCKER=true

appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ clone_folder: C:\mutagen
1010
# Set Go versions and environment variables.
1111
environment:
1212
GOROOT: C:\go112
13+
GO111MODULE: "on"
1314
MINGW_PATH: C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1
1415
MUTAGEN_TEST_END_TO_END: "full"
1516
MUTAGEN_TEST_DOCKER: "true"

0 commit comments

Comments
 (0)