Fix handshake inactivity timeout on Node.js v4.2.0

dougwilson · dougwilson · commit 2c160306ab06 · 2016-06-03T13:20:08.000-04:00
fixes #1223 fixes #1236 fixes #1239 fixes #1240 fixes #1241 fixes #1252
diff --git a/.travis.yml b/.travis.yml
@@ -7,6 +7,7 @@ node_js:
   - '1.8'
   - '2.5'
   - '3.3'
+  - '4.2.0' # Test timers regression
   - '4.4'
   - '5.11'
   - '6.2'
diff --git a/Changes.md b/Changes.md
@@ -11,6 +11,7 @@ you spot any mistakes.
 * Bind underlying connections in pool to same domain as pool #1242
 * Bind underlying socket to same domain as connection #1243
 * Fix edge cases constructing long stack traces #1387
+* Fix handshake inactivity timeout on Node.js v4.2.0 #1223 #1236 #1239 #1240 #1241 #1252
 * Fix Query stream to emit close after ending #1349 #1350
 * Fix type cast for BIGINT columns when number is negative #1376
 * Performance improvements for array/object escaping in SqlString #1331
diff --git a/lib/protocol/sequences/Sequence.js b/lib/protocol/sequences/Sequence.js
@@ -29,7 +29,7 @@ function Sequence(options, callback) {
   this._idleNext    = null;
   this._idlePrev    = null;
   this._idleStart   = null;
-  this._idleTimeout = undefined;
+  this._idleTimeout = -1;
   this._repeat      = null;
 }
 

-Original file line number
+Diff line change
   - '1.8'
   - '2.5'
   - '3.3'
 +  - '4.2.0' # Test timers regression
   - '4.4'
   - '5.11'
   - '6.2'
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ function Sequence(options, callback) {`
`29`	`29`	`this._idleNext = null;`
`30`	`30`	`this._idlePrev = null;`
`31`	`31`	`this._idleStart = null;`
`32`		`- this._idleTimeout = undefined;`
	`32`	`+ this._idleTimeout = -1;`
`33`	`33`	`this._repeat = null;`
`34`	`34`	`}`
`35`	`35`