feat(iroh): Allow connecting with "fallback" ALPNs #3282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3282/docs/iroh/ Last updated: 2025-04-30T08:43:20Z |
flub
reviewed
Apr 29, 2025
iroh/src/endpoint.rs
Outdated
| @@ -1279,6 +1281,28 @@ impl ConnectOptions { | |||
| self.transport_config = Some(transport_config); | |||
| self | |||
| } | |||
|
|
|||
| /// Sets more [ALPN] identifiers that should be signaled as supported on connection. | |||
There was a problem hiding this comment.
Suggested change
| /// Sets more [ALPN] identifiers that should be signaled as supported on connection. | |
| /// Sets multiple [ALPN] identifiers to negotiate with the server. |
There was a problem hiding this comment.
I don't like your suggestion, but it also made me dislike the current wording.
I have some ideas for something better ✌️
There was a problem hiding this comment.
Pushed something that I think is an improvement.
flub
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows connecting with multiple ALPNs so you can actually take advantage of ALPN also on the connecting side to support connections with older accept sides.
Notes & open questions
This only implements this via the
ConnectOptions, which I think is fair? I generally like the pattern ofconnect->connect_with_opts, and I don't think this is worth changingconnectfor.Closes #2949
Change checklist