fix: quote package names, resolves #64

Author: nathanhleung

src/install-peerdeps.js

@@ -42,16 +42,16 @@ const spawnCommand = (command, args) => {
     let stdout = "";
     let stderr = "";
     const cmdProcess = spawn(command + extra, args, {
-      cwd: process.cwd()
+      cwd: process.cwd(),
     });
-    cmdProcess.stdout.on("data", chunk => {
+    cmdProcess.stdout.on("data", (chunk) => {
       stdout += chunk;
     });
-    cmdProcess.stderr.on("data", chunk => {
+    cmdProcess.stderr.on("data", (chunk) => {
       stderr += chunk;
     });
     cmdProcess.on("error", reject);
-    cmdProcess.on("exit", code => {
+    cmdProcess.on("exit", (code) => {
       if (code === 0) {
         resolve(stdout);
       } else {
@@ -95,7 +95,7 @@ function findPackageVersion({ data, version }) {
 function getPackageData({ packageName, packageManager, version }) {
   const pkgString = version ? `${packageName}@${version}` : packageName;
   const args = ["info", pkgString, "--json"];
-  return spawnCommand(packageManager, args).then(response => {
+  return spawnCommand(packageManager, args).then((response) => {
     const parsed = JSON.parse(response);
     // Yarn returns with an extra nested { data } that NPM doesn't
     return parsed.data || parsed;
@@ -125,19 +125,19 @@ function getPackageJson({ packageName, noRegistry, packageManager, version }) {
 
   // Remote registry
   return getPackageData({ packageName, packageManager, version })
-    .then(data => {
+    .then((data) => {
       return Promise.resolve(
         findPackageVersion({
           data,
-          version
+          version,
         })
       );
     })
-    .then(version => {
+    .then((version) => {
       return getPackageData({
         packageName,
         packageManager,
-        version
+        version,
       });
     });
 }
@@ -191,14 +191,14 @@ function installPeerDeps(
     onlyPeers,
     silent,
     dryRun,
-    extraArgs
+    extraArgs,
   },
   cb
 ) {
   getPackageJson({ packageName, noRegistry, packageManager, version })
     // Catch before .then because the .then is so long
-    .catch(err => cb(err))
-    .then(data => {
+    .catch((err) => cb(err))
+    .then((data) => {
       // Get peer dependencies for max satisfying version
       const peerDepsVersionMap = data.peerDependencies;
       if (typeof peerDepsVersionMap === "undefined") {
@@ -213,10 +213,10 @@ function installPeerDeps(
       // only its peers.
       let packagesString = onlyPeers ? "" : `${packageName}@${data.version}`;
 
-      const packageList = Object.keys(peerDepsVersionMap).map(name =>
+      const packageList = Object.keys(peerDepsVersionMap).map((name) =>
         getPackageString({
           name,
-          version: peerDepsVersionMap[name]
+          version: peerDepsVersionMap[name],
         })
       );
 
@@ -247,7 +247,8 @@ function installPeerDeps(
           // Remove -0
           return packageName.substr(0, packageName.length - 2);
         }
-        return packageName;
+        // Fix #64 -- add quotes
+        return `"${packageName}"`;
       }
       // If we have spaces in our args spawn()
       // cries foul so we'll split the packagesString
@@ -287,7 +288,7 @@ function installPeerDeps(
       // There's a bug with Yarn 1.0 in which an empty arg
       // causes the install process to fail with a "malformed
       // response from the registry" error
-      args = args.filter(a => a !== "");
+      args = args.filter((a) => a !== "");
 
       //  Show user the command that's running
       const commandString = `${packageManager} ${args.join(" ")}\n`;
@@ -301,7 +302,7 @@ function installPeerDeps(
         console.log(commandString);
         spawnCommand(packageManager, args)
           .then(() => cb(null))
-          .catch(err => cb(err));
+          .catch((err) => cb(err));
       }
     });
 }