Skip to content

Commit 140c467

Browse files
committed
Emitting "finish" event.
1 parent 1da8b24 commit 140c467

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
Changelog
22
=========
33

4+
#### 1.0.2 (2014-09-26)
5+
6+
Now emits a "finish" event, as well as the "uploaded" event, in order to adhere to Node.js writable stream spec.
7+
48
#### 1.0.1 (2014-09-26)
59

610
Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ A pipeable write stream which uploads to Amazon S3 using the multipart file uplo
66

77
### Changelog
88

9-
#### 1.0.1 (2014-09-26)
9+
#### 1.0.2 (2014-09-26)
1010

11-
Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.
11+
Now emits a "finish" event, as well as the "uploaded" event, in order to adhere to Node.js writable stream spec.
1212

13-
#### 1.0.0 (2014-09-15)
13+
#### 1.0.1 (2014-09-26)
1414

15-
Major overhaul of the functional interface. Breaks compatability with older versions of the module in favor of a cleaner, more streamlined approach. A migration guide for users of older versions of the module has been included in the documentation.
15+
Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.
1616

1717
[Historical Changelogs](CHANGELOG.md)
1818

lib/s3-upload-stream.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ module.exports = {
213213
else {
214214
// Emit both events for backwards compatability, and to follow the spec.
215215
self.ws.emit('uploaded', result);
216-
self.ws.emit('finished', result);
216+
self.ws.emit('finish', result);
217217
}
218218
}
219219
);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "s3-upload-stream",
33
"description": "Writeable stream for uploading content of unknown size to S3 via the multipart API.",
4-
"version": "1.0.1",
4+
"version": "1.0.2",
55
"author": {
66
"name": "Nathan Peck",
77
"email": "[email protected]"

0 commit comments

Comments
 (0)