please add freebsd support package in release

[blusewang]

see title

[kozlovic]

Ironically, we would not be able to cross-compile (we use CGO_ENABLED=off) because of this commit that added freebsd support :-) a1bda5c

Adding freebsd in our cross-compile script would produce error:

Stderr: go build github.com/nats-io/nats-server/server/pse: build constraints exclude all Go files in /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/pse

which leads to: golang/go#24068.

That being said, I believe that NATS Server is part of the FreeBSD. There is a maintainer in our Slack that use to say that he updated it at each new release. Will try to reach out on Slack.

[cougarwww]

please add freebsd support package in release

[kozlovic]

@cougarwww We can't for the reason stated in previous comments. We build using CGO_ENABLED=off and the server/pse for freebsd uses C, so we would have to change that first.

[philpennock]

For clarity: the above PR which fixes this issue does so by doing exactly what @kozlovic said, because he is of course right.

The above PR adds support for cross-compiling only for FreeBSD/amd64. There are struct offsets which need to be pre-calculated on any architecture where we want to be able to avoid cgo, and I only have access to an amd64 box for this.

If you care about other hardware architectures, please take a look at the PR (which I'm cautiously optimistic will land) and create a per-architecture file in server/pse/pse_freebsd_${GOARCH}.go which does the same things. We can figure out as those arise if we want to just copy pse_freebsd_amd64.go or if it makes more sense to abstract out the per-architecture constants and endianness variable to reduce code duplication.

[philpennock]

The next release of binaries for nats-server should include a FreeBSD/amd64 binary.