Skip to content

Commit de2876b

Browse files
committed
fix(title): address review nits — gate title-set on persist success, log metadata errors
- Move set_title_if_missing call inside Ok arm so failed message persists don't produce ghost titles (ilblackdragon review) - Log metadata read errors at debug level instead of silently swallowing [skip-regression-check] https://claude.ai/code/session_01BsM2KUzdZNBeoLjk7LymZS
1 parent cbe8101 commit de2876b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/agent/thread_ops.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,9 @@ impl Agent {
10861086
}
10871087
};
10881088

1089-
crate::db::set_title_if_missing(store.as_ref(), thread_id, user_input).await;
1089+
if result.is_some() {
1090+
crate::db::set_title_if_missing(store.as_ref(), thread_id, user_input).await;
1091+
}
10901092

10911093
result
10921094
}

src/db/mod.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,11 @@ pub async fn set_title_if_missing(
514514
.get("title")
515515
.and_then(|t| t.as_str())
516516
.is_some_and(|s| !s.is_empty()),
517-
Ok(None) | Err(_) => return,
517+
Ok(None) => return,
518+
Err(e) => {
519+
tracing::debug!("failed to read metadata for title-set: {e}");
520+
return;
521+
}
518522
};
519523

520524
if !has_title {

0 commit comments

Comments
 (0)