Skip to content

Commit 2f9340c

Browse files
committed
Remove special FrontendError handling for Java and JS
1 parent 614e635 commit 2f9340c

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

tests/neo4j/test_tx_func_run.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -115,26 +115,19 @@ def run(tx):
115115
self.assertGreater(len(bookmarks[0]), 3)
116116

117117
def test_does_not_update_last_bookmark_on_rollback(self):
118-
if get_driver_name() in ["java"]:
119-
self.skipTest("Client exceptions not properly handled in backend")
120-
121118
# Verifies that last bookmarks still is empty when transactional
122119
# function rolls back transaction.
123120
def run(tx):
124121
tx.run("CREATE (n:SessionNode) RETURN n")
125122
raise ApplicationCodeError("No thanks")
126123

127124
self._session1 = self._driver.session("w")
128-
expected_exc = types.FrontendError
129-
# TODO: remove this block once all languages work
130-
with self.assertRaises(expected_exc):
125+
with self.assertRaises(types.FrontendError):
131126
self._session1.write_transaction(run)
132127
bookmarks = self._session1.last_bookmarks()
133128
self.assertEqual(len(bookmarks), 0)
134129

135130
def test_client_exception_rolls_back_change(self):
136-
if get_driver_name() in ["java"]:
137-
self.skipTest("Client exceptions not properly handled in backend")
138131
node_id = -1
139132

140133
def run(tx):
@@ -154,9 +147,6 @@ def assertion_query(tx):
154147

155148
self._session1 = self._driver.session("w")
156149
expected_exc = types.FrontendError
157-
# TODO: remove this block once all languages work
158-
if get_driver_name() in ["javascript"]:
159-
expected_exc = types.DriverError
160150
with self.assertRaises(expected_exc):
161151
self._session1.write_transaction(run)
162152

0 commit comments

Comments
 (0)