Skip to content

Commit cbc5193

Browse files
committed
Remove deprecated ResultSummary.version
1 parent d34d4f1 commit cbc5193

File tree

6 files changed

+3
-20
lines changed

6 files changed

+3
-20
lines changed

packages/core/src/result-summary.ts

-12
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,6 @@ class Notification {
459459
*/
460460
class ServerInfo {
461461
address?: string
462-
version?: string
463462
protocolVersion?: number
464463
agent?: string
465464

@@ -478,17 +477,6 @@ class ServerInfo {
478477
* @public
479478
*/
480479
this.address = serverMeta.address
481-
/**
482-
* The server version string.
483-
*
484-
* See {@link ServerInfo#protocolVersion} and {@link ServerInfo#agent}
485-
* @type {string}
486-
* @deprecated in 4.3, please use ServerInfo#agent, ServerInfo#protocolVersion, or call the <i>dbms.components</i> procedure instead.
487-
* <b>Method might be removed in the next major release.</b>
488-
489-
* @public
490-
*/
491-
this.version = serverMeta.version
492480

493481
/**
494482
* The server user agent string

packages/core/test/result-summary.test.ts

-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ describe('ServerInfo', () => {
2626
4.3,
2727
{
2828
address: '192.168.0.1',
29-
version: 'neo4j',
3029
protocolVersion: 4.3,
3130
agent: 'neo4j'
3231
}
@@ -36,7 +35,6 @@ describe('ServerInfo', () => {
3635
undefined,
3736
{
3837
address: '192.168.0.1',
39-
version: 'neo4j',
4038
protocolVersion: undefined,
4139
agent: 'neo4j'
4240
}

packages/neo4j-driver/test/session.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ describe('#integration session', () => {
193193
const sum = result.summary
194194
expect(sum.server).toBeDefined()
195195
expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
196-
expect(sum.server.version).toBeDefined()
196+
expect(sum.server.version).toBeUndefined()
197197
done()
198198
})
199199
}, 70000)

packages/neo4j-driver/test/transaction.test.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ describe('#integration transaction', () => {
311311
const sum = result.summary
312312
expect(sum.server).toBeDefined()
313313
expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
314-
expect(sum.server.version).toBeDefined()
314+
expect(sum.server.version).toBeUndefined()
315315
tx.commit().then(done)
316316
})
317317
.catch(console.log)
@@ -331,8 +331,7 @@ describe('#integration transaction', () => {
331331

332332
expect(server).toBeDefined()
333333
expect(server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
334-
expect(server.version).toBeDefined()
335-
334+
expect(server.version).toBeUndefined()
336335
done()
337336
}
338337
})

packages/neo4j-driver/test/types/driver.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ session1
101101
const close: Promise<void> = driver.close()
102102

103103
driver.verifyConnectivity().then((serverInfo: ServerInfo) => {
104-
console.log(serverInfo.version)
105104
console.log(serverInfo.address)
106105
})
107106

packages/neo4j-driver/test/types/result-summary.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ const column: number = position2.column
9898

9999
const server: ServerInfo = sum1.server
100100
const address: string | undefined = server.address
101-
const version: string | undefined = server.version
102101

103102
const resultConsumedAfter1: Integer = sum1.resultConsumedAfter
104103
const resultAvailableAfter1: Integer = sum1.resultAvailableAfter

0 commit comments

Comments
 (0)