Skip to content

Commit 8728758

Browse files
committed
🐛 Fixed MenuItem Click Issue on Mobile Devices
1 parent ec41a88 commit 8728758

File tree

9 files changed

+30
-30
lines changed

9 files changed

+30
-30
lines changed

src/Server.UI/Components/Localization/LanguageSelector.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
}
1717
else
1818
{
19-
<MudMenuItem OnClick="() => ChangeLanguageAsync(language.Name)">@language.DisplayName</MudMenuItem>
19+
<MudMenuItem OnAction="() => ChangeLanguageAsync(language.Name)">@language.DisplayName</MudMenuItem>
2020
}
2121
}
2222
}

src/Server.UI/Components/Shared/Layout/HeaderMenu.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,5 @@
6464
[EditorRequired] [Parameter] public EventCallback OpenSearchDialog { get; set; }
6565
[EditorRequired] [Parameter] public bool RightToLeft { get; set; }
6666
[EditorRequired] [Parameter] public EventCallback RightToLeftToggle { get; set; }
67-
[Parameter] public EventCallback<MouseEventArgs> OnSettingClick { get; set; }
67+
[Parameter] public EventCallback<EventArgs> OnSettingClick { get; set; }
6868
}

src/Server.UI/Components/Shared/Layout/UserMenu.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<MudText>@L["Profile"]</MudText>
5050
</div>
5151
</MudMenuItem>
52-
<MudMenuItem OnClick="OnSettingClick">
52+
<MudMenuItem OnAction="OnSettingClick">
5353
<div class="d-flex">
5454
<MudIcon Class="mx-2"
5555
Icon="@Icons.Material.Filled.Settings"/>
@@ -72,7 +72,7 @@
7272

7373
@code
7474
{
75-
[Parameter] public EventCallback<MouseEventArgs> OnSettingClick { get; set; }
75+
[Parameter] public EventCallback<EventArgs> OnSettingClick { get; set; }
7676
[Inject] public AuthenticationStateProvider AuthenticationStateProvider { get; set; } = null!;
7777
private bool IsLoading => UserProfileState.Value.IsLoading;
7878
private UserProfile UserProfile => UserProfileState.Value.UserProfile;

src/Server.UI/Pages/Customers/Customers.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,11 @@
174174
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
175175
@if (_canEdit)
176176
{
177-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
177+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
178178
}
179179
@if (_canDelete)
180180
{
181-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
181+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
182182
}
183183
</MudMenu>
184184
}

src/Server.UI/Pages/Documents/Documents.razor

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,14 @@
8787
</MudHidden>
8888
<MudHidden Breakpoint="Breakpoint.SmAndDown" Invert="true">
8989
<MudMenu AnchorOrigin="Origin.BottomLeft" StartIcon="@Icons.Material.Filled.KeyboardCommandKey" EndIcon="@Icons.Material.Filled.KeyboardArrowDown" Label="@L["Action"]" Color="Color.Primary" Variant="Variant.Filled">
90-
<MudMenuItem Disabled="@_loading" OnClick="@(() => OnRefresh())">@ConstantString.Refresh</MudMenuItem>
90+
<MudMenuItem Disabled="@_loading" OnAction="@(() => OnRefresh())">@ConstantString.Refresh</MudMenuItem>
9191
@if (_canCreate)
9292
{
93-
<MudMenuItem Disabled="@_loading" OnClick="OnCreate">@L["Upload Pictures"]</MudMenuItem>
93+
<MudMenuItem Disabled="@_loading" OnAction="OnCreate">@L["Upload Pictures"]</MudMenuItem>
9494
}
9595
@if (_canDelete)
9696
{
97-
<MudMenuItem OnClick="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
97+
<MudMenuItem OnAction="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
9898
}
9999
</MudMenu>
100100
</MudHidden>
@@ -120,15 +120,15 @@
120120
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
121121
@if (_canEdit)
122122
{
123-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
123+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
124124
}
125125
@if (_canDelete)
126126
{
127-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
127+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
128128
}
129129
@if (_canDownload)
130130
{
131-
<MudMenuItem Disabled="@_downloading" OnClick="@(() => OnDownload(context.Item))">@ConstantString.Download</MudMenuItem>
131+
<MudMenuItem Disabled="@_downloading" OnAction="@(() => OnDownload(context.Item))">@ConstantString.Download</MudMenuItem>
132132
}
133133
</MudMenu>
134134
}

src/Server.UI/Pages/Identity/Roles/Roles.razor

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,11 @@
113113
<MudMenuItem Disabled="@_loading" OnClick="@(OnRefresh)">@ConstantString.Refresh</MudMenuItem>
114114
@if (_canCreate)
115115
{
116-
<MudMenuItem OnClick="OnCreate">@ConstantString.New</MudMenuItem>
116+
<MudMenuItem OnAction="OnCreate">@ConstantString.New</MudMenuItem>
117117
}
118118
@if (_canDelete)
119119
{
120-
<MudMenuItem OnClick="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
120+
<MudMenuItem OnAction="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
121121
}
122122
</MudMenu>
123123
</MudHidden>
@@ -144,15 +144,15 @@
144144
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
145145
@if (_canEdit)
146146
{
147-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
147+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
148148
}
149149
@if (_canDelete)
150150
{
151-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
151+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
152152
}
153153
@if (_canManagePermissions)
154154
{
155-
<MudMenuItem OnClick="@(() => OnSetPermissions(context.Item))">@L["Set Permissions"]</MudMenuItem>
155+
<MudMenuItem OnAction="@(() => OnSetPermissions(context.Item))">@L["Set Permissions"]</MudMenuItem>
156156
}
157157
</MudMenu>
158158
}

src/Server.UI/Pages/Identity/Users/Users.razor

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,30 +178,30 @@
178178
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
179179
@if (_canEdit)
180180
{
181-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
181+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
182182
}
183183
@if (_canDelete)
184184
{
185-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
185+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
186186
}
187187
@if (_canManagePermissions)
188188
{
189-
<MudMenuItem OnClick="@(() => OnSetPermissions(context.Item))">@L["Set Permissions"]</MudMenuItem>
189+
<MudMenuItem OnAction="@(() => OnSetPermissions(context.Item))">@L["Set Permissions"]</MudMenuItem>
190190
}
191191
@if (_canActive)
192192
{
193193
@if (context.Item.IsActive)
194194
{
195-
<MudMenuItem OnClick=@(() => OnSetActive(context.Item))>@L["Set Inactive"]</MudMenuItem>
195+
<MudMenuItem OnAction=@(() => OnSetActive(context.Item))>@L["Set Inactive"]</MudMenuItem>
196196
}
197197
else
198198
{
199-
<MudMenuItem OnClick=@(() => OnSetActive(context.Item))>@L["Set Active"]</MudMenuItem>
199+
<MudMenuItem OnAction=@(() => OnSetActive(context.Item))>@L["Set Active"]</MudMenuItem>
200200
}
201201
}
202202
@if (_canRestPassword)
203203
{
204-
<MudMenuItem OnClick=@(() => OnResetPassword(context.Item))>@L["Reset Password"]</MudMenuItem>
204+
<MudMenuItem OnAction=@(() => OnResetPassword(context.Item))>@L["Reset Password"]</MudMenuItem>
205205
}
206206
</MudMenu>
207207
}

src/Server.UI/Pages/Products/Products.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,11 @@
188188
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
189189
@if (_canEdit)
190190
{
191-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
191+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
192192
}
193193
@if (_canDelete)
194194
{
195-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
195+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
196196
}
197197
</MudMenu>
198198
}

src/Server.UI/Pages/Tenants/Tenants.razor

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,14 @@
7272
</MudHidden>
7373
<MudHidden Breakpoint="Breakpoint.SmAndDown" Invert="true">
7474
<MudMenu AnchorOrigin="Origin.BottomLeft" StartIcon="@Icons.Material.Filled.KeyboardCommandKey" EndIcon="@Icons.Material.Filled.KeyboardArrowDown" Label="@L["Action"]" Color="Color.Primary" Variant="Variant.Filled">
75-
<MudMenuItem Disabled="@_loading" OnClick="@(() => OnRefresh())">@ConstantString.Refresh</MudMenuItem>
75+
<MudMenuItem Disabled="@_loading" OnAction="@(() => OnRefresh())">@ConstantString.Refresh</MudMenuItem>
7676
@if (_canCreate)
7777
{
78-
<MudMenuItem Disabled="@_loading" OnClick="OnCreate">@ConstantString.New</MudMenuItem>
78+
<MudMenuItem Disabled="@_loading" OnAction="OnCreate">@ConstantString.New</MudMenuItem>
7979
}
8080
@if (_canDelete)
8181
{
82-
<MudMenuItem OnClick="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
82+
<MudMenuItem OnAction="OnDeleteChecked">@ConstantString.Delete</MudMenuItem>
8383
}
8484

8585
</MudMenu>
@@ -106,11 +106,11 @@
106106
EndIcon="@Icons.Material.Filled.KeyboardArrowDown" IconColor="Color.Info" AnchorOrigin="Origin.CenterLeft">
107107
@if (_canEdit)
108108
{
109-
<MudMenuItem OnClick="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
109+
<MudMenuItem OnAction="@(() => OnEdit(context.Item))">@ConstantString.Edit</MudMenuItem>
110110
}
111111
@if (_canDelete)
112112
{
113-
<MudMenuItem OnClick="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
113+
<MudMenuItem OnAction="@(() => OnDelete(context.Item))">@ConstantString.Delete</MudMenuItem>
114114
}
115115
</MudMenu>
116116
}

0 commit comments

Comments
 (0)