Fixes #18738: Ensure ScriptList respects script_order option

Author: jnovinger

netbox/extras/models/scripts.py

@@ -117,6 +117,15 @@ def get_absolute_url(self):
     def __str__(self):
         return self.python_name
 
+    @property
+    def ordered_scripts(self):
+        script_objects = {s.name: s for s in self.scripts.all()}
+        ordered = [
+            script_objects.pop(sc) for sc in self.module_scripts.keys() if sc in script_objects
+        ]
+        ordered.extend(script_objects.items())
+        return ordered
+
     @property
     def module_scripts(self):
 

netbox/templates/extras/script_list.html

@@ -37,7 +37,7 @@ <h2 class="card-header" id="module{{ module.pk }}">
           {% endif %}
         </div>
       </h2>
-      {% with scripts=module.scripts.all %}
+      {% with scripts=module.ordered_scripts %}
         {% if scripts %}
           <table class="table table-hover scripts">
             <thead>