Skip to content

Commit d191459

Browse files
committed
Fixes: #18447 - Fix sorting by mac_address field
* Disable sorting by `mac_address` for legacy `mac_address` field for Device and VM Interfaces * Ensure `primary_mac_address` field is included in field list for Device and VM Interfaces
1 parent b913661 commit d191459

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

netbox/dcim/tables/devices.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,10 @@ class DeviceInterfaceTable(InterfaceTable):
697697
linkify=True,
698698
verbose_name=_('LAG')
699699
)
700+
mac_address = tables.Column(
701+
verbose_name=_('MAC Address'),
702+
orderable=False,
703+
)
700704
actions = columns.ActionsColumn(
701705
extra_buttons=INTERFACE_BUTTONS
702706
)
@@ -705,10 +709,10 @@ class Meta(DeviceComponentTable.Meta):
705709
model = models.Interface
706710
fields = (
707711
'pk', 'id', 'name', 'module_bay', 'module', 'label', 'enabled', 'type', 'parent', 'bridge', 'lag',
708-
'mgmt_only', 'mtu', 'mode', 'mac_address', 'wwn', 'rf_role', 'rf_channel', 'rf_channel_frequency',
709-
'rf_channel_width', 'tx_power', 'description', 'mark_connected', 'cable', 'cable_color', 'wireless_link',
710-
'wireless_lans', 'link_peer', 'connection', 'tags', 'vdcs', 'vrf', 'l2vpn', 'tunnel', 'ip_addresses',
711-
'fhrp_groups', 'untagged_vlan', 'tagged_vlans', 'qinq_svlan', 'actions',
712+
'mgmt_only', 'mtu', 'mode', 'mac_address', 'primary_mac_address', 'wwn', 'rf_role', 'rf_channel',
713+
'rf_channel_frequency', 'rf_channel_width', 'tx_power', 'description', 'mark_connected', 'cable',
714+
'cable_color', 'wireless_link', 'wireless_lans', 'link_peer', 'connection', 'tags', 'vdcs', 'vrf', 'l2vpn',
715+
'tunnel', 'ip_addresses', 'fhrp_groups', 'untagged_vlan', 'tagged_vlans', 'qinq_svlan', 'actions',
712716
)
713717
default_columns = (
714718
'pk', 'name', 'label', 'enabled', 'type', 'parent', 'lag', 'mtu', 'mode', 'description', 'ip_addresses',

netbox/virtualization/tables/virtualmachines.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,19 @@ class VMInterfaceTable(BaseInterfaceTable):
113113
verbose_name=_('VRF'),
114114
linkify=True
115115
)
116+
mac_address = tables.Column(
117+
verbose_name=_('MAC Address'),
118+
orderable=False,
119+
)
116120
tags = columns.TagColumn(
117121
url_name='virtualization:vminterface_list'
118122
)
119123

120124
class Meta(NetBoxTable.Meta):
121125
model = VMInterface
122126
fields = (
123-
'pk', 'id', 'name', 'virtual_machine', 'enabled', 'mac_address', 'mtu', 'mode', 'description', 'tags',
124-
'vrf', 'primary_mac_address', 'l2vpn', 'tunnel', 'ip_addresses', 'fhrp_groups', 'untagged_vlan',
127+
'pk', 'id', 'name', 'virtual_machine', 'enabled', 'mtu', 'mode', 'description', 'tags', 'vrf',
128+
'mac_address', 'primary_mac_address', 'l2vpn', 'tunnel', 'ip_addresses', 'fhrp_groups', 'untagged_vlan',
125129
'tagged_vlans', 'qinq_svlan', 'created', 'last_updated',
126130
)
127131
default_columns = ('pk', 'name', 'virtual_machine', 'enabled', 'description')

0 commit comments

Comments
 (0)