Fixes: #19228 - Fix ordered_scripts to only return ordered list of script objects

DanSheps · DanSheps · commit e0a85159a68e · 2025-04-23T13:32:19.000-05:00
diff --git a/netbox/extras/models/scripts.py b/netbox/extras/models/scripts.py
@@ -123,7 +123,7 @@ def ordered_scripts(self):
         ordered = [
             script_objects.pop(sc) for sc in self.module_scripts.keys() if sc in script_objects
         ]
-        ordered.extend(script_objects.items())
+        ordered.extend(script_objects.values())
         return ordered
 
     @property

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ def ordered_scripts(self):`
`123`	`123`	`ordered = [`
`124`	`124`	`script_objects.pop(sc) for sc in self.module_scripts.keys() if sc in script_objects`
`125`	`125`	`]`
`126`		`- ordered.extend(script_objects.items())`
	`126`	`+ ordered.extend(script_objects.values())`
`127`	`127`	`return ordered`
`128`	`128`
`129`	`129`	`@property`