Skip to content

GetReturnURLMixin Support for Plugin Views #16144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9er-tom opened this issue May 15, 2024 · 1 comment · Fixed by #18996
Closed

GetReturnURLMixin Support for Plugin Views #16144

9er-tom opened this issue May 15, 2024 · 1 comment · Fixed by #18996
Assignees
@renatoalmeidaoliveira
Labels
complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: feature Introduction of new functionality to the application
Milestone
v4.2.7

Comments

@9er-tom
Copy link

9er-tom commented May 15, 2024

NetBox version

v3.7.3

Feature type

Change to existing functionality

Proposed functionality

The automatic return URL generation for views (specifically object edit views) should be compatible with plugin views.

Currently only core views are supported as get_return_url() in netbox/utilities/views.py:137 does not include the "plugins:" namespace

Use case

This would alleviate the need for specifying default_return_url for plugin views

Database changes

No response

External dependencies

No response
@9er-tom 9er-tom added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 15, 2024
@abhi1693 abhi1693 removed their assignment May 15, 2024
@abhi1693 abhi1693 added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 15, 2024
@jeremystretch jeremystretch added complexity: medium Requires a substantial but not unusual amount of effort to implement status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation topic: plugins Relates to the plugins framework complexity: low Requires minimal effort to implement and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation complexity: medium Requires a substantial but not unusual amount of effort to implement labels May 21, 2024
@jeremystretch jeremystretch added status: backlog Awaiting selection for work and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 30, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@alexblaeuer
Copy link

I also run into this issue while developing a plugin and added the feature in my fork by getting the viewname of the model (alexblaeuer@693b10b). Can I open a PR for this issue?

@jnovinger jnovinger added status: accepted This issue has been accepted for implementation and removed status: backlog Awaiting selection for work labels Mar 24, 2025
Merged
@jeremystretch jeremystretch added this to the v4.2.7 milestone Mar 27, 2025
@jeremystretch jeremystretch mentioned this issue Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renatoalmeidaoliveira renatoalmeidaoliveira

Labels
complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation topic: plugins Relates to the plugins framework type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.2.7
Development

Successfully merging a pull request may close this issue.

Fixes: #16144 GetReturnURLMixin Support for Plugin Views renatoalmeidaoliveira/netbox
6 participants
@jnovinger @abhi1693 @alexblaeuer @jeremystretch @renatoalmeidaoliveira @9er-tom