Skip to content

Crammed column views for mobile devices #17613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alryaz opened this issue Sep 26, 2024 · 4 comments · Fixed by #19251
Closed

Crammed column views for mobile devices #17613

alryaz opened this issue Sep 26, 2024 · 4 comments · Fixed by #19251
Assignees
Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Milestone

Comments

@alryaz
Copy link

alryaz commented Sep 26, 2024

Deployment Type

Self-hosted

NetBox Version

v4.1.1

Python Version

3.11

Steps to Reproduce

  1. Create a prefix (any family, any value)
  2. Open newly created prefix on a mobile device (≤1440px width at ≥440ppi)
  3. Columns appear horizontally

Expected Behavior

All columns display vertically (one above the other)

Observed Behavior

Columns behave horizontally, text overlaps (for lengthy values)

Additional information

This is the result of using class="col col-md-6". An opportunity for improvement lies within adding col-12 to the class list.

This likely applies to the following templates:

  • users/objectpermission.html
  • users/user.html
  • users/group.html
  • users/token.html
  • generic/confirmation_form.html
  • extras/object_configcontext.html
  • extras/webhook.html
  • extras/tag.html
  • extras/customfield.html
  • extras/customfieldchoiceset.html
  • extras/eventrule.html
  • extras/notificationgroup.html
  • ipam/vrf.html
  • ipam/routetarget.html
  • ipam/prefix.html
  • ipam/asn.html
  • ipam/rir.html
  • ipam/vlan.html
  • ipam/asnrange.html
  • ipam/servicetemplate.html
  • ipam/fhrpgroup.html
  • ipam/role.html
  • ipam/vlangroup.html
  • ipam/aggregate.html
  • ipam/service.html
  • ipam/iprange.html
  • virtualization/virtualmachine.html
  • virtualization/virtualdisk.html
  • virtualization/vminterface.html
  • virtualization/cluster_add_devices.html
  • virtualization/clustergroup.html
  • virtualization/clustertype.html
  • virtualization/cluster.html
  • core/objectchange.html
  • core/datasource.html
  • core/job.html
  • vpn/ipsecproposal.html
  • vpn/ikeproposal.html
  • vpn/tunneltermination.html
  • vpn/l2vpn.html
  • vpn/l2vpntermination.html
  • vpn/tunnelgroup.html
  • vpn/ipsecpolicy.html
  • vpn/ipsecprofile.html
  • vpn/ikepolicy.html
  • vpn/tunnel.html
  • dcim/devicetype.html
  • dcim/sitegroup.html
  • dcim/rack.html
  • dcim/interface.html
  • dcim/site.html
  • dcim/powerport.html
  • dcim/platform.html
  • dcim/moduletype.html
  • dcim/virtualdevicecontext.html
  • dcim/rackrole.html
  • dcim/powerpanel.html
  • dcim/region.html
  • dcim/consoleserverport.html
  • dcim/frontport.html
  • dcim/modulebay.html
  • dcim/rearport.html
  • dcim/poweroutlet.html
  • dcim/manufacturer.html
  • dcim/inventoryitemrole.html
  • dcim/inventoryitem.html
  • dcim/rackreservation.html
  • dcim/devicebay.html
  • dcim/device.html
  • dcim/devicerole.html
  • dcim/cable.html
  • dcim/devicebay_populate.html
  • dcim/module.html
  • dcim/consoleport.html
  • dcim/powerfeed.html
  • dcim/location.html
  • wireless/wirelesslan.html
  • wireless/wirelesslangroup.html
  • wireless/wirelesslink.html
  • tenancy/contactgroup.html
  • tenancy/tenantgroup.html
  • tenancy/contactrole.html
  • account/profile.html
  • circuits/circuittype.html
  • circuits/circuitgroup.html
  • circuits/provider.html
  • circuits/circuittermination.html
  • circuits/provideraccount.html
  • circuits/circuit.html
  • circuits/circuitgroupassignment.html
  • circuits/providernetwork.html
@alryaz alryaz added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Sep 26, 2024
@alryaz
Copy link
Author

alryaz commented Sep 26, 2024

Quick fix I applied to my installation:
find netbox/templates/ -type f -name \*.html -print0 | xargs -0 sed -i 's/"col col-md-6"/"col col-12 col-md-6"/g'

@arthanson
Copy link
Collaborator

Screenshot showing the issue
10 112 0 0:15 | NetBox 2024-09-26 07-53-43

@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Sep 26, 2024
@alryaz
Copy link
Author

alryaz commented Sep 30, 2024

I am happy to do a PR if such fix is sufficient (my branch: https://github.com/alryaz/netbox/tree/patch-column-widths )

@arthanson
Copy link
Collaborator

@alryaz I'm assigning to you as it sounds like a you have a potential fix for a PR.

@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Oct 10, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Dec 26, 2024
@arthanson arthanson self-assigned this Apr 21, 2025
@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 21, 2025
@jeremystretch jeremystretch added this to the v4.2.9 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants